Ensure that the jump buffer is appropriately aligned.#86
Open
gareth-rees wants to merge 1 commit into59-memory-awarefrom
Open
Ensure that the jump buffer is appropriately aligned.#86gareth-rees wants to merge 1 commit into59-memory-awarefrom
gareth-rees wants to merge 1 commit into59-memory-awarefrom
Conversation
gareth-rees
force-pushed
the
59-memory-aware
branch
from
b71e18c to
e089937
Compare
gareth-rees
force-pushed
the
84-sc-align
branch
from
03f8716 to
c947406
Compare
Contributor
thejayps
added
the
essential
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stack capturing mechanism in
STACK_CONTEXT_BEGINputs theStackContextStructon the stack, where it will later be scanned usingTraceScanArea. ThejumpBuffermust be allocated on the stack at an address with suitable alignment so thatTraceScanAreawill correctly fix any addresses therein. On platform XCA6LL,jmp_bufis declared as an array ofint, which has 4-byte alignment, but we need it to have 8-byte alignment in order to correctly interpret the contents.This addresses fifteen of the seventeen MMQA test failures in issue #84.