design(meetup): 모임 찾기 스켈레톤 추가#346
Merged
Merged
Conversation
PollyGotACracker
requested review from
Geunone2,
aabyess,
doxmt,
jay0425 and
sohyun0
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces skeleton UI components for the meetup list and filters, refactoring the list structure to support better loading states. The review feedback highlights several structural and logic issues: the
- element incorrectly contains non-
- direct children (violating HTML specifications), the Suspense wrapper is redundant because the component handles its own loading state instead of suspending, and the refetching opacity styles are applied to individual items rather than the parent container, which breaks the intended CSS transitions.
|
🧷 Preview: https://reboot-1kd2d5dx6-code-base.vercel.app |
|
🧷 Preview: https://reboot-7s0z9ze2q-code-base.vercel.app |
|
🧷 Preview: https://reboot-cn9bihfxv-code-base.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ 설명 (Description)
모임 찾기 페이지에서 스켈레톤을 추가하였습니다.
📝 변경 사항 요약 (Summary)
💁 변경 사항 이유 (Why)
✅ 테스트 계획 (Test Plan)
🔗 관련 이슈 (Related Issues)
☑️ 체크리스트 (Checklist)