refactor(meetup): 모임 찾기, 만들기 관련 리팩토링#357
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request centralizes API error handling using a new throwApiError utility and refactors the meetup list logic by introducing helper functions for building requests and queries. It also updates validation logic for meetup creation and moves constants to a dedicated file. Feedback suggests decoupling constants from UI components to reduce coupling and renaming capacity validation functions to improve clarity, as the current naming is counter-intuitive for minimum value checks.
…355-refactor-meetup
|
🧷 Preview: https://reboot-73g6b5kp8-code-base.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ 설명 (Description)
모임 찾기, 만들기 관련 코드를 리팩토링하였습니다.
📄 설계 문서 (Design Document)
관련 설계 문서나 위키 페이지가 있다면 링크를 추가해주세요.(하위 항목 노션링크 첨부)
📝 변경 사항 요약 (Summary)
validateDateTimeIsFuturevalidateDateTimeOrdervalidateMaxCapacityvalidateCapacity수정: 최소 인원은 고려하지 않도록 변경,validateMaxCapacity와 함께 활용throwApiError적용💁 변경 사항 이유 (Why)
✅ 테스트 계획 (Test Plan)
🔗 관련 이슈 (Related Issues)
☑️ 체크리스트 (Checklist)
👀 리뷰어를 위한 참고 사항 (Notes for Reviewers)
MIN_CONFIRMED_COUNT값은 meetupDetail 에서 import 하였습니다.MIN_CONFIRMED_COUNT값 검토가 필요합니다.현재 값은 3으로 작성되었습니다.