fix(meetupDetail): 만료된 테스트 픽스처 날짜 교체#359
Merged
Merged
Conversation
- 고정값인 날짜가 현재 시각 기준으로 과거 값이되는 문제 해결 Resolves: #358
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates test data dates to the year 2099 to prevent test expiration. Feedback suggests using dynamic dates or fake timers instead of hardcoding far-future years to improve long-term maintainability. Additionally, a logical inconsistency was identified in util.test.ts where the registration end date is set after the meeting date, which should be corrected to maintain realistic test data.
|
🧷 Preview: https://reboot-rokr1isbf-code-base.vercel.app |
jay0425
approved these changes
May 4, 2026
Collaborator
jay0425
left a comment
jay0425
left a comment
There was a problem hiding this comment.
빠른 수정 감사합니다. 바로 머지해주셔도 좋을거 같습니다.
|
🧷 Preview: https://reboot-kkmwdwnur-code-base.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ 설명 (Description)
테스트 데이터의 날짜가, 현재 시각 기준으로 과거 날짜로 전환됨으로써,
날짜/마감 유효성 검사에서 의도치않게 필터링되는 문제가 발생했습니다.
이를 해결하기 위해, 테스트 데이터의 날짜를 일부 조정하였습니다.
📄 설계 문서 (Design Document)
📝 변경 사항 요약 (Summary)
2099 ~) 값으로 설정💁 변경 사항 이유 (Why)
✅ 테스트 계획 (Test Plan)
🔗 관련 이슈 (Related Issues)
☑️ 체크리스트 (Checklist)
👀 리뷰어를 위한 참고 사항 (Notes for Reviewers)
해당 문제를 해결하기 위해 미래 날짜(
2099~)로 변경하였습니다.➕ 추가 정보 (Additional Information)