Bugfixes: Transmission FOM, stress hour reporting, planned transmission - #151
Merged
Conversation
… to objective_function_params.yaml
atpham88
reviewed
Jul 23, 2026
atpham88
left a comment
Contributor
There was a problem hiding this comment.
Thanks very much Patrick. I just have 2 small comments.
atpham88
approved these changes
Jul 23, 2026
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three bugs:
Technical details
Implementation notes
hours_t(allh,t)parameter (likeh_t(allh,t)to keep track of changing stress period hour weights over model yearstransmission.pyAdditional changes
objective_function_params.yamlused incheck_inputs.pysitemap.h5andsc_point_gid_old2new.csvfiles, which are out of date (thanks @sriharisundar for noticing)reeds.io.get_folder_size(): Now reports total folder size instead of just outputs; changed units to MB to avoid too much rounding incompare_cases.pyIssues resolved
report.gms: Fixhoursfor pre-final-year stress periods #146Validation, testing, and comparison report(s)
20260724
Here's an updated USA_defaults comparison: results-v20260724_mainK0_USA_defaults,v20260724_bugsK0_USA_defaults.pptx. The differences are pretty much the same as in the 20260716 comparison above.
Checklist for author
Details to double-check
General information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
Nope