Skip to content

Add Korean multicontext Hangul factor dataset with POS tagging (korean_pos_mc) - #872

Merged
gkielian merged 1 commit into
ReaLLMASIC:masterfrom
kahye:kahye-korean-pos-mc
Aug 2, 2026
Merged

Add Korean multicontext Hangul factor dataset with POS tagging (korean_pos_mc)#872
gkielian merged 1 commit into
ReaLLMASIC:masterfrom
kahye:kahye-korean-pos-mc

Conversation

@kahye

@kahye kahye commented Jul 28, 2026

Copy link
Copy Markdown

This PR introduces part-of-speech (POS) tagging to the Korean multicontext Hangul factorization
pipeline, expanding syllable decomposition to 24 lanes.

Key Changes

• New Dataset (data/korean_pos_mc): Adds dataset pipeline, experiment scripts, and lane metadata
for 24-lane Korean multicontext (23 structural Hangul features + 1 POS tagging lane via
kiwipiepy).
• Factorization & Stream Extraction: Updates hangul_factorizer.py, extract_multicontext_streams.
py, and make_multicontext_prompt.py to support POS tag lane generation (--use-pos).
• Testing & Demos: Adds unit tests (test_hangul_factorizer.py) and an end-to-end demo script
(korean_pos_multicontext_demo.sh).
• Training & Visualizations: Minor enhancements to train.py and the 3D vocabulary sphere
visualization app (hf-vocab-sphere) to support the updated multicontext streams.

@kahye

kahye commented Jul 28, 2026

Copy link
Copy Markdown
Author

@gkielian Can you review this PR? Not sure how to add you as a reviewer on this PR.

@msaligane
msaligane requested a review from gkielian July 28, 2026 21:10
@gkielian

Copy link
Copy Markdown
Collaborator

Wow this is great! : D

Looking forward to trying this out.

Btw, noticed the input.txt were pretty large files -- would it be possible to instead of placing the input.txt files and other large files -- to instead place generator bash scripts that will create these?

image

@kahye
kahye force-pushed the kahye-korean-pos-mc branch from b29a669 to 24d9887 Compare July 30, 2026 00:03
@kahye

kahye commented Jul 30, 2026

Copy link
Copy Markdown
Author

Wow this is great! : D

Looking forward to trying this out.

Btw, noticed the input.txt were pretty large files -- would it be possible to instead of placing the input.txt files and other large files -- to instead place generator bash scripts that will create these?

image

Great catch. I reverted all the txt changes in this folder since they can be recovered by running get_dataset.sh

@kahye
kahye force-pushed the kahye-korean-pos-mc branch from 24d9887 to bbb52f5 Compare July 31, 2026 19:43

@gkielian gkielian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! : D

@gkielian
gkielian merged commit 8b07d0d into ReaLLMASIC:master Aug 2, 2026
0 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants