Add Korean multicontext Hangul factor dataset with POS tagging (korean_pos_mc) - #872
Merged
Merged
Conversation
Author
|
@gkielian Can you review this PR? Not sure how to add you as a reviewer on this PR. |
Collaborator
kahye
force-pushed
the
kahye-korean-pos-mc
branch
from
July 30, 2026 00:03
b29a669 to
24d9887
Compare
Author
kahye
force-pushed
the
kahye-korean-pos-mc
branch
from
July 31, 2026 19:43
24d9887 to
bbb52f5
Compare
gkielian
approved these changes
Aug 2, 2026
gkielian
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thanks! : D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR introduces part-of-speech (POS) tagging to the Korean multicontext Hangul factorization
pipeline, expanding syllable decomposition to 24 lanes.
Key Changes
• New Dataset (data/korean_pos_mc): Adds dataset pipeline, experiment scripts, and lane metadata
for 24-lane Korean multicontext (23 structural Hangul features + 1 POS tagging lane via
kiwipiepy).
• Factorization & Stream Extraction: Updates hangul_factorizer.py, extract_multicontext_streams.
py, and make_multicontext_prompt.py to support POS tag lane generation (--use-pos).
• Testing & Demos: Adds unit tests (test_hangul_factorizer.py) and an end-to-end demo script
(korean_pos_multicontext_demo.sh).
• Training & Visualizations: Minor enhancements to train.py and the 3D vocabulary sphere
visualization app (hf-vocab-sphere) to support the updated multicontext streams.