Support queued subscribers with CapturingSubscribableBus#186
Merged
Conversation
- Implements a `SingleThreadedBus` to support unit tests. - Uses that bus as the internal bus in `CapturingSubscribableBus`, along with additional logic to deal with queued handling of commands. - Adds tests for `CapturingSubscribableBus` to cover both synchronous handling and queued handling of commands.
condron
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
The
CapturingSubscribableBusreturns fromSendbefore the command has been handled if the subscriber uses an internal queue for its subscriptions. This breaks the blocking paradigm ofSendthat is intended for tests under the capturing bus.How does this pull request accomplish that goal?
SingleThreadedBusto support unit tests.CapturingSubscribableBus, along with additional logic to deal with queued handling of commands.CapturingSubscribableBusto cover both synchronous handling and queued handling of commands.Why is this pull request important?
Tests of services that use, e.g. a
QueuedSubscriberwould need to implement additional logic similar toWaitForunlessSendand its variants block until the command is handled.Link to any issues that this resolves
This does not address any open issues.
Checklist