Adds async versions of ReadModelBase.Start()#191
Merged
Conversation
b13ecfc to
da59976
Compare
Adds a `StartAsync` method for each overload of `Start` in `ReadModelBase`. These methods perform event playback on a task pool thread. The class exposes an awaitable `IsLive` property that completes when all async playback Tasks have completed.
da59976 to
761d21b
Compare
condron
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Enables a mechanism to determine when a read model is live using
async-awaitinstead of usingblockUntilLivein calls toStart.How does this pull request accomplish that goal?
Adds a
StartAsyncmethod for each overload ofStartinReadModelBase. These methods perform event playback on a task pool thread. The class exposes an awaitableIsLiveproperty that completes when all async playback Tasks have completed.Why is this pull request important?
The use of
blockUntilLivecan cause problems when running unit tests in the lightweight VMs that are often used for CI builds. The problem is thatStart<T>(blockUntilLive: true)synchronously blocks a taskpool thread while waiting for the stream reader to catch up. On a runner with a small number of cores, even sequential tests within one assembly can starve the pool if multipleReadModelBaseinstances are constructed in quick succession since each test class creates fresh RMs in its constructor.Link to any issues that this resolves
This does not address any open issues.
Checklist