MockStreamStoreConnection avoids "collection modified" error during disposal#198
Merged
Merged
Conversation
joshkempner
force-pushed
the
joshkempner/mockstreamstore-locks
branch
3 times, most recently
from
4d3048e to
8749931
Compare
joshkempner
force-pushed
the
joshkempner/mockstreamstore-locks
branch
from
8749931 to
869bd4e
Compare
…isposal - Extends the use of the existing lock to prevent the collection of subscriptions from being modified during disposal. - Fixes flaky unit tests
joshkempner
force-pushed
the
joshkempner/mockstreamstore-locks
branch
from
869bd4e to
aedf572
Compare
condron
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
MockStreamStoreConnectionavoids "collection modified" error during disposal.How does this pull request accomplish that goal?
Extends the use of the existing lock to prevent the collection of subscriptions from being modified during disposal.
Why is this pull request important?
This could cause occasional failures in unit tests in projects that rely on
MockStreamStoreConnection.Link to any issues that this resolves
This does not address any open issues.
Checklist
NB
This PR also fixes an issue with the formatting check in the PR build checks, fixes line endings that caused that to fail, and fixes a few flaky tests that at first appeared to be related to the
MockStreamStoreConnectionchange, but turned out to be pre-existing issues.