Add functionality to update acknowledgement with path request#87
Draft
Add functionality to update acknowledgement with path request#87
Conversation
yesyash
requested review from
harshith-venkatesh,
iRohitGaur and
prakashchoudhary07
yesyash
commented
Apr 6, 2023
Collaborator
Author
There was a problem hiding this comment.
You can ignore this file as it is to fix the typescript eslint issue and got caught in this PR.
DeRaowl
suggested changes
Apr 7, 2023
| }); | ||
|
|
||
| if (updatedData && updatedData.acknowledgement === status) { | ||
| return res.json({ message: 'Acknowledgement status updated' }); |
There was a problem hiding this comment.
Can we move messages to constant files.
Collaborator
Author
There was a problem hiding this comment.
As the message is specifically used for this controller will this change be required?
| attendeeId: z.preprocess((a) => Number(a), z.number().positive()), | ||
| }), | ||
| body: z.object({ | ||
| status: z.enum(['ACCEPTED', 'DECLINED', 'TENTATIVE']), |
isVivek99
reviewed
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #51
Changes made:
acknowledgmentfor an event.Note
There are four types of
acknowledgmentsan attendee can have:The API endpoint will only accept
Accepted,Declined&Tentativeas the new status to update because we wouldn't want anacknowledgmentto be set back toAwaitingafter the user has taken action to mark their acknowledgment.Todo:
authenticationmiddleware.