revamped Stock listing page UI, closes #298#302
revamped Stock listing page UI, closes #298#302aakashjangra wants to merge 3 commits intoRealDevSquad:developfrom
Conversation
changes color of stock cards and position of sell stocks button
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
closes #298 |
MehulKChaudhari
left a comment
MehulKChaudhari
left a comment
There was a problem hiding this comment.
Hey, I was testing out locally. But I cannot visit upon the page it gave me this error. Please handle it. User should barely get such errors on the screen.
Also please add the demo you use for the development. So I can test it out easily. And keep that data for now once we have API ready we will remove dummy data and use actual data.
Thank you.
|
Thanks for the review. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| font-size: 1.1em; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: end; |
There was a problem hiding this comment.
The CSS property align-items: end is not standard CSS and may cause compatibility issues across browsers. For better cross-browser compatibility, use align-items: flex-end instead. This is the standard value in the CSS Flexbox specification.
| align-items: end; | |
| align-items: flex-end; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
2 participants
@MehulKChaudhari Please review it and let me know of the required changes if any.
Thank you,
Akash