This repository was archived by the owner on Mar 1, 2025. It is now read-only.
infinite scroll for new members#397
Open
Ishikabaid wants to merge 6 commits intoRealDevSquad:developfrom
Open
Conversation
sumitd94
reviewed
Aug 6, 2022
Ishikabaid
force-pushed
the
infiniteScroll
branch
from
83ff59b to
ef62093
Compare
sumitd94
reviewed
Aug 23, 2022
heyrandhir
reviewed
Aug 31, 2022
Comment on lines
+46
to
+47
| useEffect(() => { | ||
| fetchNewMembers(); | ||
| }, [newMembersList]); |
Contributor
There was a problem hiding this comment.
we can add the fetchNewMembers function in the dependency array as pointed out in the warning by GitHub actions.
Contributor
Author
There was a problem hiding this comment.
Can you please tell me why we need to provide this function in the dependency array?
Contributor
There was a problem hiding this comment.
Since the hook is dependent on the function, I thought we can add it. what do you think @sumitd94 @swarajpure ?
swarajpure
reviewed
Sep 1, 2022
sumitd94
reviewed
Sep 1, 2022
sumitd94
reviewed
Sep 1, 2022
| const { dev } = query; | ||
| const [isOptionKey, setIsOptionKey] = useState(false); | ||
| const [newMembers, setNewMembers] = useState([]); | ||
| const [scrollCount, setScrollCount] = useState(0); |
Contributor
There was a problem hiding this comment.
Why do we need this scroll count?
Contributor
Author
There was a problem hiding this comment.
We need this count to update the array of new members to show after every scroll and we are using it inside fetchNewMembers function.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prakashchoudhary07
approved these changes
Sep 14, 2022
Ishikabaid
force-pushed
the
infiniteScroll
branch
from
7d1ae3c to
fb0d052
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Closes #391
Implemented infinite scroll for new members
Is it bug?
No
*Dev Tested?
Yes
*Tested on:
Platforms
Browsers
Before / After Change Screenshots
Untitled.1.mp4