[Fix] - Task Card Enhacement (milestone-1) by Pratiyushkumar · Pull Request #510 · RealDevSquad/website-my

Pratiyushkumar · 2023-10-28T13:37:07Z

Date: 11-02-2023

Developer Name: Pratiyush

Issue

[Fix] - Task Card Enhacement (milestone-1) #509

Description

UI changes are done where Extension Status button has been renamed by Request Extension. After the task is 100% completed and the status is Completed then the Extension Request button should not be visible. Some of unwanted statuses which were not in use have been removed like - smoke Testing, sanity check, Regression Check, Released, verified, Needs Review, Approved and feature is put behind the feature flag.

Is Development Tested?

Yes
No

Under Feature Flag

Yes
No

Database changes

Yes
No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

Yes
No

Deployment notes
Any special instructions for the deployment (none)

Before Changes

bandicam.2023-11-02.12-16-59-900.mp4

After changes

bandicam.2023-11-02.06-59-13-844.mp4

bandicam.2023-11-02.23-25-00-436.mp4

Test Coverage

netlify · 2023-10-28T13:37:11Z

✅ Deploy Preview for staging-my ready!

Name	Link
🔨 Latest commit	`edf6b54`
🔍 Latest deploy log	https://app.netlify.com/sites/staging-my/deploys/655ab272a3cd05000821f0f9
😎 Deploy Preview	https://deploy-preview-510--staging-my.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shubhamsinghbundela · 2023-10-30T08:32:00Z

I think Once status change to completed then don't allow to change other status from select tag

Pratiyushkumar · 2023-10-30T08:50:04Z

I think Once status change to completed then don't allow to change other status from select tab

why so??

shubhamsinghbundela · 2023-10-30T09:04:24Z

Completed means DONE, In rds We all know done defination i.e. our changes is in prod.
if you have confusion please discuss once with @iamitprakash @ankushdharkar

iamitprakash

is In_progess color is yellow ..?

iamitprakash · 2023-10-30T19:02:06Z

I think Once status change to completed then don't allow to change other status from select tag

yes, true @shubhamsigdar1 @Pratiyushkumar

iamitprakash · 2023-10-30T19:03:16Z

I think Once status change to completed then don't allow to change other status from select tab

why so??

once task has been marked completed, can you please explain the reason to put back into in-progress

Pratiyushkumar · 2023-10-31T06:05:14Z

as been marked completed, can you please explain the reason to put back into in-progres

since the start date is not mentioned hence it shows color yellow

Pratiyushkumar · 2023-10-31T08:02:17Z

I think Once status change to completed then don't allow to change other status from select tag

fixed

shubhamsinghbundela

Didn't understand the commit message and the changes you did :)

Ajeyakrishna-k · 2023-10-31T14:18:20Z

I think the card height should not change once its completed.
Why is the status COMPLETED before IN REVIEW?
I also think we should still show the status as completed on the card and disable it instead of removing it from the card.

iamitprakash · 2023-10-31T18:06:03Z

as been marked completed, can you please explain the reason to put back into in-progres

since the start date is not mentioned hence it shows color yellow

can you pass me the documentation link

Pratiyushkumar · 2023-11-01T14:20:34Z

as been marked completed, can you please explain the reason to put back into in-progres

since the start date is not mentioned hence it shows color yellow

can you pass me the documentation link

#497
Here it is

Pratiyushkumar · 2023-11-02T01:30:58Z

I think the card height should not change once its completed.

Why is the status COMPLETED before IN REVIEW?

I also think we should still show the status as completed on the card and disable it instead of removing it from the card.

done

iamitprakash

Please add proper details

iamitprakash

As this is UI changes demo would be needed for approval

Pratiyushkumar · 2023-11-02T04:49:57Z

Please add proper details

what kind of details is missing, please guide me I will mention it

Pratiyushkumar · 2023-11-02T04:50:42Z

As this is UI changes demo would be needed for approval

when can I present DEMO

iamitprakash

after changing status to done, why dropdown is enable or showing down array...?

Pratiyushkumar · 2023-11-02T17:30:28Z

after changing status to done, why dropdown is enable or showing down array...?

Drop down button gets disabled, user cannot update status again as per @Ajeyakrishna-k review comment.

Pratiyushkumar · 2023-11-02T17:57:55Z

after changing status to done, why dropdown is enable or showing down array...?

done the changes

… visible

…eature flag

Pratiyushkumar added 2 commits October 28, 2023 19:06

Milestone-1 completed

0944b90

add the holder.hbs file

9b1064b

Pratiyushkumar changed the title ~~Fix/milestone 1~~ [Fix] - Task Card Enhacement (milestone-1) Oct 28, 2023

Pratiyushkumar self-assigned this Oct 29, 2023

constant file also updated

d511446

iamitprakash requested changes Oct 30, 2023

View reviewed changes

on complete status task status should not get completed

f2bf38f

shubhamsinghbundela reviewed Oct 31, 2023

View reviewed changes

merge conflict resolved

153b430

Pratiyushkumar added 2 commits November 1, 2023 21:49

chnaged the working of DONE status

a1ef6d4

Dropdown button disbled

5fc0768

Ajeyakrishna-k reviewed Nov 2, 2023

View reviewed changes

resolved the PR comments

fdcaad1

Ajeyakrishna-k previously approved these changes Nov 2, 2023

View reviewed changes

iamitprakash requested changes Nov 2, 2023

View reviewed changes

Pratiyushkumar requested a review from iamitprakash November 2, 2023 05:06

sahsisunny previously approved these changes Nov 2, 2023

View reviewed changes

iamitprakash requested review from Ajeyakrishna-k and sahsisunny November 2, 2023 05:41

iamitprakash requested changes Nov 2, 2023

View reviewed changes

dropdown arrow button removed

5297033

Pratiyushkumar dismissed stale reviews from sahsisunny and Ajeyakrishna-k via 5297033 November 2, 2023 17:57

Pratiyushkumar added 2 commits November 3, 2023 10:55

added test case if status is done then extension button should not be…

ac6c776

… visible

added test case to check if the status are visible with and without f…

8d16168

…eature flag

prakashchoudhary07 reviewed Nov 3, 2023

View reviewed changes

Comment thread app/components/task-tabs.hbs Outdated

Pratiyushkumar requested review from iamitprakash, prakashchoudhary07 and shubhamsinghbundela November 3, 2023 07:00

Pratiyushkumar added 2 commits November 3, 2023 14:27

removed the string with constant value

fbb29a4

task tabs.js file seperated

367a304

shubhamsinghbundela reviewed Nov 3, 2023

View reviewed changes

Comment thread app/components/task-tabs.hbs Outdated

Comment thread app/components/task/holder.hbs

bhtibrewal added 2 commits November 20, 2023 06:26

minor name change

1679cca

refactor the code

edf6b54

Conversation

Pratiyushkumar commented Oct 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Description

Is Development Tested?

Under Feature Flag

Before Changes

After changes

Test Coverage

Uh oh!

netlify Bot commented Oct 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for staging-my ready!

Uh oh!

shubhamsinghbundela commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pratiyushkumar commented Oct 30, 2023

Uh oh!

shubhamsinghbundela commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamitprakash left a comment

Choose a reason for hiding this comment

Uh oh!

iamitprakash commented Oct 30, 2023

Uh oh!

iamitprakash commented Oct 30, 2023

Uh oh!

Pratiyushkumar commented Oct 31, 2023

Uh oh!

Pratiyushkumar commented Oct 31, 2023

Uh oh!

shubhamsinghbundela left a comment

Choose a reason for hiding this comment

Uh oh!

Ajeyakrishna-k commented Oct 31, 2023

Uh oh!

iamitprakash commented Oct 31, 2023

Uh oh!

Pratiyushkumar commented Nov 1, 2023

Uh oh!

Pratiyushkumar commented Nov 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iamitprakash left a comment

Choose a reason for hiding this comment

Uh oh!

iamitprakash left a comment

Choose a reason for hiding this comment

Uh oh!

Pratiyushkumar commented Nov 2, 2023

Uh oh!

Pratiyushkumar commented Nov 2, 2023

Uh oh!

iamitprakash left a comment

Choose a reason for hiding this comment

Uh oh!

Pratiyushkumar commented Nov 2, 2023

Uh oh!

Pratiyushkumar commented Nov 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Pratiyushkumar commented Oct 28, 2023 •

edited

Loading

netlify Bot commented Oct 28, 2023 •

edited

Loading

shubhamsinghbundela commented Oct 30, 2023 •

edited

Loading

shubhamsinghbundela commented Oct 30, 2023 •

edited

Loading