Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* main branch * create folder to my project * add crud * fix post issue * finish create operation * add post * update completed * Update SamuelBlogPost.vue string literal rather than concat * Update SamuelAddBlog.vue remove unnecessary code. * Update SamuelAddBlog.vue change by object and remove unnecessary code * Update SamuelBlogPost.vue * Update SamuelBlogPost.vue * Update samuel.js * restore * fix issue * remove unnessasry code * add changes
* [web] implement blog list * [web] minor refractions made * [web] implemented authentication * [web] lintfix * [web] implemented authentication * [web] refractions made on auth * [web] fixed comments on PR * Yared.demo project UI (#270) * create the UI * [web] implement vuex state management * [web] implement CRUD functionalities * [web] add authentication and fix previous comments * [WEB]: folder restructure to work with team * [web]: sample structure for the demo * [web]: folder rename to PascalCase * [web]: remove feature folder from store * [web]: fix a bug inside index page * [web]: fix deployment bug * Yohans.web.demo (#256) * [web][yohans] added some basic ui and simple database mocking array * [web][yohans] added some state for the blogs * [WEB]: folder restructure * [web]: sample structure for the demo * [web]: remove feature folder from store * [web]: file rename issue with git solved * [WEB]: fix deploy error * [web] implemented authentication * [web] refractions made on auth * [web] implement blog list * [web] implemented authentication * [web] lintfix * [web] fixed comments on PR * [web] comments fixed and lintfix Co-authored-by: Yared <90713646+Yared04@users.noreply.github.com> Co-authored-by: Mintesnot Bezabhi <61611671+Mintaa911@users.noreply.github.com> Co-authored-by: Yohans Hailu <95067604+YohansHailu@users.noreply.github.com>
Comment on lines
5
to
8
| :title="blog.title" | ||
| :fullName="blog.authorUserId.fullName" | ||
| :tag="blog.tag" | ||
| :content="blog.content" |
Contributor
There was a problem hiding this comment.
Instead of passing individual properties, it is better to pass the object as props
| @@ -0,0 +1,26 @@ | |||
| <template> | |||
| <v-card class="mx-auto deep-purple" min-height="250" max-width="344"> | |||
Contributor
There was a problem hiding this comment.
The texts on the cards are not readable. Go for something lighter.
| @@ -0,0 +1,26 @@ | |||
| <template> | |||
| <v-card class="mx-auto deep-purple" min-height="250" max-width="344"> | |||
Contributor
There was a problem hiding this comment.
The texts on the cards are not readable. Go for something lighter.
danielgitk
reviewed
Aug 4, 2022
| @@ -0,0 +1,33 @@ | |||
| <template> | |||
| <button @click="$emit('toggle-task')">{{ text }}</button> | |||
Contributor
There was a problem hiding this comment.
I would recommend using a vuetify button. and using classes to make it look how you want it to. check more about it here but if you needed this exact component, It's ok
* [web] remove .vue files from coverage reports * [web] add store files to coverage reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.