Kick AFK Players#46
Open
Arc676 wants to merge 9 commits intoRealFloorIsJava:masterfrom
Arc676:kick-afkers
Open
Kick AFK Players#46Arc676 wants to merge 9 commits intoRealFloorIsJava:masterfrom Arc676:kick-afkers
Arc676 wants to merge 9 commits intoRealFloorIsJava:masterfrom
Arc676:kick-afkers
Conversation
Count rounds in which players do nothing Check if 2 rounds or more when picking Modified _pick_possible for use with AFK checking
Track AFK users by PID rather than name Kicked users just stop updating
Abandoning participant takes default argument "left." Kicking for AFK uses custom message Pickers not choosing no longer considered AFK
Mark picker as AFK for a round if no winner is picked Stop tracking player's AFK rounds when participant abandoned
Reset AFK round count on chat send
Added some documentation
Default 2 rounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Matchclass now keeps a record of how many rounds players spent exhibiting AFK-behavior. If a picker does not choose a winner or does not choose a card, this counts as AFK-activity. Choosing a card or picking a winner resets the player's AFK round count to 0. If any player's AFK round count is at least 2 during the COOLDOWN phase, that player is kicked, ungracefully i.e. the client's UI freezes. This should be improved (send a message to the client and show an error page or something).Not picking a winner when there aren't enough choices does not count as AFK-behavior.
Kicking players for being AFK for too long adds a custom error message to the chat.
Closes #19.