Blank cards#49
Open
Arc676 wants to merge 49 commits intoRealFloorIsJava:masterfrom
Arc676:blank-cards
Open
Conversation
Defaults to server owner Match phase skip method now takes nickname argument Follow 80 char line convention Fixed syntax error in match.js
Indicates who wants to skip Indicates how many skips required to reach majority
Checking for majority now O(n) time Prevent same user from making multiple skip requests user_can_skip_phase now takes participant argument
Fixed to use new function call Added argument to comment for user_can_skip_phase
POST request handler can also return numbers If parameter doesn't have a filename, assume it's the wild card counter instead
Get wild card count from POST request
Added WILD type to API
(Card set needs resizing) No longer try to replenish wild cards
Server side API can change card text Changed to `is not None` for more Python-y-ness and consistency
Increased wild card limit to 100
Moved queue building and picking to separate methods Build queue when creating MultiDeck
Added default text to wild cards Now says "Wild card" instead of being empty
Added method for determining participant hand size Use participant hand size to determine size of available card pool Probability of drawing wild card depends on size of card pool Particpant.replenish_hand now returns number of cards drawn
Draw fewer cards if wild cards in hand
Collaborator
Author
|
I'll resolve the merge conflicts after #47 is merged. |
Defaults to server owner Match phase skip method now takes nickname argument Follow 80 char line convention Fixed syntax error in match.js
Indicates who wants to skip Indicates how many skips required to reach majority
Checking for majority now O(n) time Prevent same user from making multiple skip requests user_can_skip_phase now takes participant argument
Fixed to use new function call Added argument to comment for user_can_skip_phase
POST request handler can also return numbers If parameter doesn't have a filename, assume it's the wild card counter instead
Get wild card count from POST request
Added WILD type to API
(Card set needs resizing) No longer try to replenish wild cards
Server side API can change card text Changed to `is not None` for more Python-y-ness and consistency
Increased wild card limit to 100
Moved queue building and picking to separate methods Build queue when creating MultiDeck
Added default text to wild cards Now says "Wild card" instead of being empty
Added method for determining participant hand size Use participant hand size to determine size of available card pool Probability of drawing wild card depends on size of card pool Particpant.replenish_hand now returns number of cards drawn
Draw fewer cards if wild cards in hand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I unintentionally branched this off
configurable-skipsso PR #47 has to be merged before this one.Implemented wild cards
Closes #37.