Open
Conversation
|
Hi Jacob, Your project looks great! Thanks for working on this. FYI These two flags are for release builds, with them you won't be able to catch DCHECK failures and see other debug log information if needed. This means that you don't get any console output upon failures, for example when the arena is too small for the model. It might make sense to be able to overwrite them when needed. |
Contributor
Author
|
Greetings thanks for stopping by @wangtz Please keep us and c linking workflow in mind in upstream :) Im just a consumer, @richardeoin and @Recognition2 have the commits. I dont think we utilize or export the DCHECK stuff so shouldnt be a problem, but we can also match on std::env::var("PROFILE") for debug and release to enable conditionally instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw a ticket come through on tflite worrying about assert debug costs if you dont use the release build and I thought... hrmm. Are we building with those flags?
tensorflow/tensorflow#44863 (comment)
Doesnt seem like it, so adding these two defines
https://github.com/tensorflow/tensorflow/blob/acd6f26bbaa2f747b88bfd480c6d607b4836b9ef/tensorflow/lite/micro/tools/make/Makefile#L200
drops 18812 bytes
I havent checked the cycle count, but that would be interesting