Remove CryticToFoundry assertion shim and rely on fail_on_assert#2
Open
Remove CryticToFoundry assertion shim and rely on fail_on_assert#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foundry-rs/foundry#13322fail_on_assert = trueinfoundry.tomlassert(false)incounter_incrementcatch pathinvariant_counter_incrementcampaignscript/ci/check_fuzzer.shFoundry check to require:invariant_number_is_small()failureinvariant_number_change_requires_sequence()failureassertion failure in counter_incrementValidation
Using local
forgefrom Foundry (with the pending assertion-emission changes):../foundry/target/debug/forge test --mc CryticToFoundryPATH=../foundry/target/debug:$PATH FOUNDRY_INVARIANT_CONTINUOUS_RUN=false script/ci/check_fuzzer.sh foundryObserved in logs:
assertion failure in counter_increment ...invariant_number_change_requires_sequence()failsinvariant_number_is_small()failsBlocker
This PR is blocked by (and intended to land with) the Foundry fix for: