Various rendering improvements#134
Merged
RecursivePineapple merged 8 commits intomasterfrom Dec 17, 2025
Merged
Conversation
Owner
RecursivePineapple
commented
Dec 17, 2025
RecursivePineapple
commented
- Optimize BoxRenderer
- VBO improvements + use SharedDrawable
- Pull VertexBuffer into its own class and improve it
mitchej123
reviewed
Dec 17, 2025
...in/java/com/recursive_pineapple/matter_manipulator/common/items/manipulator/RenderHints.java
Outdated
Show resolved
Hide resolved
|
Would highly encourage some unit tests to ensure these function as expected. Also some of the improvements might make sense to make available in gtnhlib (now or later) |
eigenraven
reviewed
Dec 17, 2025
Comment on lines
24
to
37
| @Getter | ||
| protected volatile int id; | ||
| @Getter | ||
| protected volatile int vertexCount; | ||
|
|
||
| @Getter | ||
| protected volatile long length; | ||
| @Getter | ||
| protected volatile int bufferFlags; | ||
|
|
||
| @Getter | ||
| protected volatile ByteBuffer mappedBuffer; | ||
| @Getter | ||
| protected volatile boolean mapped; |
There was a problem hiding this comment.
If you need to make sure multiple fields are synchronized across threads, wrap accesses to them in a proper lock as volatile does not give the appropriate thread safety guarantees
Owner
Author
There was a problem hiding this comment.
I added proper synchronization. Hopefully it's in the correct locations, I'm not sure what should be synchronized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.