feat(RHINENG-23947): Add Kessel perms#1521
Conversation
9f0ff68 to
f8fd928
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1521 +/- ##
==========================================
- Coverage 73.67% 72.30% -1.37%
==========================================
Files 97 99 +2
Lines 2359 2405 +46
Branches 666 677 +11
==========================================
+ Hits 1738 1739 +1
- Misses 551 586 +35
- Partials 70 80 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
67fc0ca to
57493c9
Compare
LightOfHeaven1994
left a comment
There was a problem hiding this comment.
Found few things to fix, otherwise I think it looks good. I wasn't able to test it properly because patchman backend times out
57493c9 to
4017eaf
Compare
|
Thanks for the review @LightOfHeaven1994 , working on testing this now |
LightOfHeaven1994
left a comment
There was a problem hiding this comment.
PR looks good to me 👍
I don't know why playwright tests are failing. Seems in reality this app checks only read permissions. I see there is template:write permission but it's not really used as patch is divided to two GH repositories.
4017eaf to
dc8d790
Compare
|
I pushed the fix to 'useAccessCheckContext must be used within an AccessCheckProvider' that other services were experiencing, |
Integrate Kessel permission checks behind the
patch-frontend.kessel-enabled feature flag.
When Kessel is enabled, permission checks use the
Kessel SDK (useSelfAccessCheck) against workspace
resources instead of RBAC v1. When disabled,
behavior is unchanged.
Permission mapping (from patch.ksl):
Description
RHINENG-23947
Please include a summary of the change, what this fixes/creates/improves.
-Integrate Kessel permission checks behind the
patch-frontend.kessel-enabled feature flag.
from @project-kessel/react-kessel-access-check SDK
WithPermission, SystemsTable, PatchSet, and
PatchSetDetail with usePermissionCheck
How to test the PR
Please include steps to test your PR.
Before the change
After the change
Dependent work link
Checklist: