Skip to content

chore: increase memory limit for konflux builds#2253

Merged
jdobes merged 1 commit intoRedHatInsights:masterfrom
RostyslavKachan:add_memory_for_konflux_pipelines
Mar 13, 2026
Merged

chore: increase memory limit for konflux builds#2253
jdobes merged 1 commit intoRedHatInsights:masterfrom
RostyslavKachan:add_memory_for_konflux_pipelines

Conversation

@RostyslavKachan
Copy link
Collaborator

@RostyslavKachan RostyslavKachan commented Mar 12, 2026

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Summary by Sourcery

Build:

  • Configure build-container steps in Tekton pull-request and push pipelines to request and limit 8Gi memory for the build step.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 12, 2026

Reviewer's Guide

Adjusts Tekton pipeline configurations to increase memory requests and limits to 8Gi for the container build step across PR and push workflows for both standard and SC vulnerability-engine builds.

File-Level Changes

Change Details Files
Increase memory resources for the container build step in all vulnerability-engine Tekton pipelines.
  • Add taskRunSpecs for the build-container pipeline task in each pipeline definition.
  • Configure the build step within build-container to request 8Gi of memory.
  • Set memory limit to 8Gi for the build step to match the request, ensuring consistent resource allocation across PR and push pipelines for both standard and SC builds.
.tekton/vulnerability-engine-pull-request.yaml
.tekton/vulnerability-engine-push.yaml
.tekton/vulnerability-engine-sc-pull-request.yaml
.tekton/vulnerability-engine-sc-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Contributor

SC Environment Impact Assessment

Overall Impact:NONE

No SC Environment-specific impacts detected in this PR.

What was checked

This PR was automatically scanned for:

  • Database migrations
  • ClowdApp configuration changes
  • Kessel integration changes
  • AWS service integrations (S3, RDS, ElastiCache)
  • Kafka topic changes
  • Secrets management changes
  • External dependencies

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The 8Gi memory requests/limits are duplicated across all four Tekton pipeline specs; consider pulling this into a shared template/overlays or using a param so future resource changes stay consistent across pipelines.
  • You are setting requests and limits to the same 8Gi value for the build step, which forces a Guaranteed QoS pod; if that’s not explicitly required, consider using a lower request than limit or adding a short rationale in the pipeline config for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The 8Gi memory requests/limits are duplicated across all four Tekton pipeline specs; consider pulling this into a shared template/overlays or using a param so future resource changes stay consistent across pipelines.
- You are setting requests and limits to the same 8Gi value for the `build` step, which forces a Guaranteed QoS pod; if that’s not explicitly required, consider using a lower request than limit or adding a short rationale in the pipeline config for future maintainers.

## Individual Comments

### Comment 1
<location path=".tekton/vulnerability-engine-push.yaml" line_range="42-49" />
<code_context>
+  - pipelineTaskName: build-container
+    stepSpecs:
+    - name: build
+      computeResources:
+        requests:
+          memory: 8Gi
+        limits:
+          memory: 8Gi
</code_context>
<issue_to_address>
**suggestion (performance):** Consider specifying CPU resources alongside memory for more predictable scheduling.

Currently only memory is set. For build steps, CPU is a key driver of performance and scheduling. Please add appropriate `cpu` requests/limits so the scheduler can place this workload more predictably and reduce noisy-neighbor issues on shared nodes.

```suggestion
  - pipelineTaskName: build-container
    stepSpecs:
    - name: build
      computeResources:
        requests:
          memory: 8Gi
          cpu: "2"
        limits:
          memory: 8Gi
          cpu: "2"
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +42 to +49
- pipelineTaskName: build-container
stepSpecs:
- name: build
computeResources:
requests:
memory: 8Gi
limits:
memory: 8Gi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Consider specifying CPU resources alongside memory for more predictable scheduling.

Currently only memory is set. For build steps, CPU is a key driver of performance and scheduling. Please add appropriate cpu requests/limits so the scheduler can place this workload more predictably and reduce noisy-neighbor issues on shared nodes.

Suggested change
- pipelineTaskName: build-container
stepSpecs:
- name: build
computeResources:
requests:
memory: 8Gi
limits:
memory: 8Gi
- pipelineTaskName: build-container
stepSpecs:
- name: build
computeResources:
requests:
memory: 8Gi
cpu: "2"
limits:
memory: 8Gi
cpu: "2"

@RostyslavKachan RostyslavKachan force-pushed the add_memory_for_konflux_pipelines branch 4 times, most recently from 825998c to 09feb8e Compare March 13, 2026 10:31
@RostyslavKachan
Copy link
Collaborator Author

/retest

@RostyslavKachan RostyslavKachan force-pushed the add_memory_for_konflux_pipelines branch from 09feb8e to d0cb5ce Compare March 13, 2026 15:00
@jdobes jdobes merged commit d6721eb into RedHatInsights:master Mar 13, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants