chore: increase memory limit for konflux builds#2253
chore: increase memory limit for konflux builds#2253jdobes merged 1 commit intoRedHatInsights:masterfrom
Conversation
Reviewer's GuideAdjusts Tekton pipeline configurations to increase memory requests and limits to 8Gi for the container build step across PR and push workflows for both standard and SC vulnerability-engine builds. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
SC Environment Impact AssessmentOverall Impact: ⚪ NONE No SC Environment-specific impacts detected in this PR. What was checkedThis PR was automatically scanned for:
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The 8Gi memory requests/limits are duplicated across all four Tekton pipeline specs; consider pulling this into a shared template/overlays or using a param so future resource changes stay consistent across pipelines.
- You are setting requests and limits to the same 8Gi value for the
buildstep, which forces a Guaranteed QoS pod; if that’s not explicitly required, consider using a lower request than limit or adding a short rationale in the pipeline config for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The 8Gi memory requests/limits are duplicated across all four Tekton pipeline specs; consider pulling this into a shared template/overlays or using a param so future resource changes stay consistent across pipelines.
- You are setting requests and limits to the same 8Gi value for the `build` step, which forces a Guaranteed QoS pod; if that’s not explicitly required, consider using a lower request than limit or adding a short rationale in the pipeline config for future maintainers.
## Individual Comments
### Comment 1
<location path=".tekton/vulnerability-engine-push.yaml" line_range="42-49" />
<code_context>
+ - pipelineTaskName: build-container
+ stepSpecs:
+ - name: build
+ computeResources:
+ requests:
+ memory: 8Gi
+ limits:
+ memory: 8Gi
</code_context>
<issue_to_address>
**suggestion (performance):** Consider specifying CPU resources alongside memory for more predictable scheduling.
Currently only memory is set. For build steps, CPU is a key driver of performance and scheduling. Please add appropriate `cpu` requests/limits so the scheduler can place this workload more predictably and reduce noisy-neighbor issues on shared nodes.
```suggestion
- pipelineTaskName: build-container
stepSpecs:
- name: build
computeResources:
requests:
memory: 8Gi
cpu: "2"
limits:
memory: 8Gi
cpu: "2"
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| - pipelineTaskName: build-container | ||
| stepSpecs: | ||
| - name: build | ||
| computeResources: | ||
| requests: | ||
| memory: 8Gi | ||
| limits: | ||
| memory: 8Gi |
There was a problem hiding this comment.
suggestion (performance): Consider specifying CPU resources alongside memory for more predictable scheduling.
Currently only memory is set. For build steps, CPU is a key driver of performance and scheduling. Please add appropriate cpu requests/limits so the scheduler can place this workload more predictably and reduce noisy-neighbor issues on shared nodes.
| - pipelineTaskName: build-container | |
| stepSpecs: | |
| - name: build | |
| computeResources: | |
| requests: | |
| memory: 8Gi | |
| limits: | |
| memory: 8Gi | |
| - pipelineTaskName: build-container | |
| stepSpecs: | |
| - name: build | |
| computeResources: | |
| requests: | |
| memory: 8Gi | |
| cpu: "2" | |
| limits: | |
| memory: 8Gi | |
| cpu: "2" |
825998c to
09feb8e
Compare
|
/retest |
09feb8e to
d0cb5ce
Compare
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist
Summary by Sourcery
Build: