Remove unused jira-escalation command and SlackClient bot integration#276
Draft
amp-rh wants to merge 1 commit into
Draft
Remove unused jira-escalation command and SlackClient bot integration#276amp-rh wants to merge 1 commit into
amp-rh wants to merge 1 commit into
Conversation
Neither the jira-escalation CLI command nor the SlackClient bot token integration were wired up to any CI job or Prow step. Removing the dead code: jira_escalation command, escalation logic, SlackClient class, and associated tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead code that was never wired up to any CI job or Prow step:
src/commands/jira_escalation.py— CLI commandsrc/escalation/jira_escalation.py— escalation logicsrc/objects/slack_base.py— SlackClient bot token integrationWhy
The
jira-escalationcommand andSlackClient(bot token based) existed in the codebase but were never referenced in the step registry or any Prow job config.SLACK_BOT_TOKENwas never injected anywhere in CI.Slack notifications for the
reportcommand are handled via incoming webhook in #274, which requires no bot token or SDK.Test plan
uv run pytest tests/unittests/)firewatch --helpno longer listsjira-escalation