feat: add watchers, additional assignees, and per-rule Slack labels to firewatch rules#277
Open
amp-rh wants to merge 1 commit into
Open
feat: add watchers, additional assignees, and per-rule Slack labels to firewatch rules#277amp-rh wants to merge 1 commit into
amp-rh wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
This was referenced May 4, 2026
Closed
Add rule fields for Jira watchers, additional assignees, slack channel, and slack user routing, wire them through report issue creation and labels, and document Slack Workflow Builder integration. Include smoke scripts and expanded unit/e2e coverage, including slack-user label normalization to username-only test values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends firewatch rules so CI failures produce richer Jira issues and Automation-friendly Slack routing without adding Slack tokens or webhooks to the firewatch workload.
jira_watchers: list of emails; watchers are added after issue create (best effort; unresolvable users log a warning and are skipped).jira_additional_assignees: list of emails; sets the Red Hat Jira Additional Assignees field (customfield_10465) after create (best effort).slack_channel/slack_user: optional strings; firewatch adds Jira labelsslack-channel:<name>(#stripped) andslack-user:<sanitized-email>(@→-at-) so Jira Automation rules (for exampleSend web requestto a Slack Workflow) can route notifications per rule.!defaultfor email lists: whenjira_watchersorjira_additional_assigneescontains!default, values are merged fromFIREWATCH_DEFAULT_JIRA_WATCHERS/FIREWATCH_DEFAULT_JIRA_ADDITIONAL_ASSIGNEES(JSON arrays). Firewatch exits with an error if!defaultis used but the corresponding env var is missing or empty after parsing (stricter than optional defaults on some other fields).Rule reference: docs/configuration_guide.md.
openshift-ci smoke replay (local)
development/env.list.examplelists env vars for replayingfirewatch reportagainst a completed Prow job.make smoke-openshift-cirunsscripts/smoke-openshift-ci-replay.sh(jira-config-gen+firewatch reportwith--keep-job-dir).Tests and tooling
JIRA_EMAILis set.types-requestsfor mypy; e2e may load repo-root.envviapython-dotenv.tests/.New rule fields
jira_watchersjira_additional_assigneescustomfield_10465)slack_channelslack-channel:<channel>slack_userslack-user:<sanitized-email>Test plan
pre-commit run --all-filesResolves INTEROP-8865, INTEROP-8979