Skip to content

CherryPicked: [v2.10] feat(MTV-4803): per-disk xcopyUsed verification for mixed datastore migration#534

Merged
rh-bot-1 merged 1 commit into
v2.10from
CherryPicked-feat/MTV-4803-mixed-datastore-xcopy-verification-epu4H
Jun 2, 2026
Merged

CherryPicked: [v2.10] feat(MTV-4803): per-disk xcopyUsed verification for mixed datastore migration#534
rh-bot-1 merged 1 commit into
v2.10from
CherryPicked-feat/MTV-4803-mixed-datastore-xcopy-verification-epu4H

Conversation

@manage-repositories-app
Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #529, PR owner: prabinovRedhat

…igration (#529)

* feat(MTV-4803): add per-disk xcopyUsed check for mixed datastore test

Add verify_mixed_datastore_xcopy_used() and test_check_xcopy_used on
TestCopyoffloadMixedDatastoreMigration. Expected xcopyUsed is derived from
provider copyoffload datastore_id (1) and non_xcopy_datastore_id (0); pod
logs are correlated via resolved vSphere datastore display names.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(MTV-4803): generalize per-datastore xcopyUsed verification

Replace verify_mixed_datastore_xcopy_used with verify_xcopy_used_per_datastore,
accepting expected_xcopy_by_datastore_id for any number of datastores.

Co-authored-by: Cursor <cursoragent@cursor.com>

* improve(copyoffload): enrich xcopy log parsing and failure diagnostics

Read populate pod logs once per disk, surface the last xcopyUsed log line,
and raise a clear error when copy-offload fails before xcopyUsed is logged.

Co-authored-by: Cursor <cursoragent@cursor.com>

* improve(copyoffload): log expected vs actual xcopyUsed per populate pod

Include PASS/FAIL and the source log line in xcopy verification INFO logs.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
@rh-bot-1
Copy link
Copy Markdown

rh-bot-1 commented Jun 1, 2026

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

Note: You are an auto-verified user. Your PRs will be automatically verified and may be auto-merged when all requirements are met.

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: Disabled for this repository
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: All label categories are enabled (default configuration)

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /automerge - Enable automatic merging when all requirements are met (maintainers and approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest conventional-title - Validate commit message format
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. Status Checks: All required status checks must pass
  3. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  4. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • myakove
  • solenoci

Reviewers:

  • krcmarik
  • myakove
  • solenoci
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
  • automerge
AI Features
  • Conventional Title: Mode: fix (claude/claude-opus-4-6[1m])
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])
  • Test Oracle: Triggers: approved (cursor/gpt-5.4-xhigh-fast); /test-oracle can be used anytime

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@myakove
Copy link
Copy Markdown
Collaborator

myakove commented Jun 2, 2026

/lgtm
/approve

@rh-bot-1 rh-bot-1 merged commit e698e0e into v2.10 Jun 2, 2026
6 checks passed
@rh-bot-1 rh-bot-1 deleted the CherryPicked-feat/MTV-4803-mixed-datastore-xcopy-verification-epu4H branch June 2, 2026 06:50
@redhat-qe-bot
Copy link
Copy Markdown

New container for ghcr.io/redhatqe/mtv-api-tests:v2.10 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants