feat: add guest-side assertion guidance to JOB_INSIGHT_PROMPT

[vsibirsk]

Short description:

Steer AI triage away from defaulting to TimeoutSampler on guest SSH assertion failures — mismatch can be permanent due to wrong observable, unit conversion, or rounding, not timing. Add AssertionError signal entry and a new section covering known systematic mismatches (MemTotal, df, HugePages) and the one-sample-≠-convergence rule.

Assisted-by: Cursor (Claude Sonnet 4.6)

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• Documentation
  • Expanded failure-handling guidance with detailed rules for exception patterns and comprehensive validation scenario coverage.
  • Added new best practices section addressing systematic mismatches between guest-side assertions and API specifications, including unit conversion issues, discrete vs. continuous value differences, and OS measurement inconsistencies.
  • Enhanced code-fix recommendations with detailed validation verification guidelines to prevent misdiagnosis of issues.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: cde9eb4f-4768-45d0-8bc2-7f730173d6a0

📥 Commits

Reviewing files that changed from the base of the PR and between 968a40a and c9e85ab.

📒 Files selected for processing (1)

• JOB_INSIGHT_PROMPT.md

---

📝 Walkthrough

Walkthrough

Updated JOB_INSIGHT_PROMPT.md to expand failure-handling guidance for guest SSH assertions. Added explicit checklist for verifying observables, units, and comparisons before recommending TimeoutSampler. Introduced new section on distinguishing guest-visible validation mismatches from timing issues, covering unit conversions, rounding, and known measurement differences. Refined code-fix suggestions to avoid defaulting to TimeoutSampler without ruling out wrong observable or assertion.

Changes

Guest SSH Assertion Failure Guidance

Layer / File(s)	Summary
Exception-Pattern Checklist JOB_INSIGHT_PROMPT.md (lines 195–201)	Added explicit guidance for AssertionError arising from guest SSH comparisons, with a checklist to verify observable correctness, unit consistency, and comparison logic before considering TimeoutSampler.
Systematic Mismatch Reference JOB_INSIGHT_PROMPT.md (lines 244–270)	New "Guest-visible validation vs API or spec" section that distinguishes observable mismatches from timing issues by naming exact observables, validating reachable comparisons, and accounting for discrete-vs-continuous and spec rounding mismatches (e.g., MemTotal, df, hugepage units).
Code-Fix Guidance Refinement JOB_INSIGHT_PROMPT.md (lines 305–307)	Reinforced instruction to prohibit defaulting to TimeoutSampler until wrong observable, unit, and assertion issues are ruled out.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding guest-side assertion guidance to an AI triage prompt document.
Description check	✅ Passed	The description has a complete short description explaining the purpose and key additions, but lacks content for most other template sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-virtualization-qe-bot-2]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• RoniKishner
• dshchedr
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

AI Features

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.