net: Mark localnet tests#4751
Conversation
Signed-off-by: Yossi Segev <ysegev@redhat.com> Assisted by: Claude Code
📝 WalkthroughWalkthroughThis PR adds a new pytest marker called ChangesLocalnet Pytest Marker Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/build-and-push-container |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-5
requested review from
Anatw,
RoniKishner,
dshchedr,
frenzyfriday,
orelmisan,
rnetser,
servolkov and
vsibirsk
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pytest.ini (1)
1-118:⚠️ Potential issue | 🟠 Major | ⚡ Quick winHIGH: PR description is missing all required template sections.
The PR description provided contains no template sections. Per the repo's PR template (
.github/pull_request_template.md), the following sections are required even if left empty:
##### What this PR does / why we need it:— must have meaningful content##### Which issue(s) this PR fixes:##### Special notes for reviewer:##### jira-ticket:Please restore them. As per coding guidelines: "Flag as HIGH if the section is missing, empty, whitespace-only..."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pytest.ini` around lines 1 - 118, The PR description is missing required template sections from .github/pull_request_template.md; update the PR description to include the headings "##### What this PR does / why we need it:", "##### Which issue(s) this PR fixes:", "##### Special notes for reviewer:", and "##### jira-ticket:" and fill them with meaningful (non-empty, non-whitespace) content or explicit “None” where applicable so the PR passes the repo validation; ensure the entries describe purpose, linked issues, reviewer notes, and jira ticket ID (or state none).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@pytest.ini`:
- Around line 1-118: The PR description is missing required template sections
from .github/pull_request_template.md; update the PR description to include the
headings "##### What this PR does / why we need it:", "##### Which issue(s) this
PR fixes:", "##### Special notes for reviewer:", and "##### jira-ticket:" and
fill them with meaningful (non-empty, non-whitespace) content or explicit “None”
where applicable so the PR passes the repo validation; ensure the entries
describe purpose, linked issues, reviewer notes, and jira ticket ID (or state
none).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3e574678-2ff7-45ac-92d8-0ec24a6f2b6d
📒 Files selected for processing (6)
pytest.initests/network/localnet/ipam/test_connectivity.pytests/network/localnet/migration_stuntime/test_migration_stuntime.pytests/network/localnet/test_default_bridge.pytests/network/localnet/test_jumbo_frames.pytests/network/localnet/test_ovs_bridge.py
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4751 published |
|
/verified Verified that localnet tests are not collected when filtering-out the marker ( Without filtering-out - all localnet tests are collected: $ uv run pytest --verbose --jira -rs -s -o log_cli=true --junitxml=xunit_results.xml --pytest-log-file=pytest-tests.log --leftovers-collector --tb=native --skip-deprecated-api-test --cluster-sanity-skip-storage-check tests/network/localnet --collect-only $ uv run pytest --verbose --jira -rs -s -o log_cli=true --junitxml=xunit_results.xml --pytest-log-file=pytest-tests.log --leftovers-collector --tb=native --skip-deprecated-api-test --cluster-sanity-skip-storage-check tests/network/localnet -m not localnet --collect-only |
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
| rwx_default_storage: Tests that require RWX storage | ||
| descheduler: Tests that require kube-descheduler on nodes | ||
| remote_cluster: Tests that require a remote cluster | ||
| localnet: Tests that use node localnet topology |
There was a problem hiding this comment.
Test Execution Plan
- Run smoke tests: False (No dependency path found from smoke tests to changed files — changes are marker-only additions with no fixture, utility, or conftest modifications)
Verify marker filtering works correctly:
-m localnet— Confirm all 7/8 localnet tests are collected across all modified files-m not localnet— Confirm no localnet tests are collected (as validated by PR author)
Individual files to spot-check collection:
tests/network/localnet/ipam/test_connectivity.pytests/network/localnet/migration_stuntime/test_migration_stuntime.pytests/network/localnet/test_default_bridge.pytests/network/localnet/test_jumbo_frames.pytests/network/localnet/test_ovs_bridge.py
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 3216 🏁 Script executed: Length of output: 3487 |
6 participants
One immediate benefit from marking the localnet tests is that localnet is not supported on cloud-providers clusters, so it makes it easier to filter them out when running on such clusters (for example - heterogeneous multi-arch clusters are currently only applicable such clusters).
Assisted by: Claude Code