IUO: Multiarch STD by hmeir · Pull Request #4763 · RedHatQE/openshift-virtualization-tests

hmeir · 2026-05-06T15:27:44Z

Short description:

Multiarch std

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

https://redhat.atlassian.net/browse/CNV-78180

Summary by CodeRabbit

Tests
- Added comprehensive test coverage for multi-architecture boot source resources and pointer DataSources across different architectures
- Added test coverage validating multi-architecture golden image metrics, including annotation misconfiguration detection and configuration behavior
- Expanded test scenarios covering both enabled and disabled multi-architecture configurations, including nodePlacement impact on metrics

Signed-off-by: Harel Meir <hmeir@redhat.com>

coderabbitai · 2026-05-06T15:27:59Z

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This PR adds two new test modules to validate multi-architecture golden image functionality: one module tests architecture-specific boot source resources and pointer DataSources, while the other module tests metrics behavior when multi-arch support is enabled or disabled across heterogeneous clusters.

Changes

Multi-Architecture Golden Image Tests

Layer / File(s)	Summary
Test Framework & Structure `tests/install_upgrade_operators/hco_enablement_golden_image_updates/multiarch/test_multiarch_boot_sources.py`, `tests/install_upgrade_operators/hco_enablement_golden_image_updates/multiarch/test_multiarch_golden_image_metrics.py`	Module headers with STP references and preconditions; module-level pytest marks (`multiarch`, `post_upgrade`, `incremental`) and `__test__` flags applied to both files.
Boot Source Resource Tests `tests/install_upgrade_operators/hco_enablement_golden_image_updates/multiarch/test_multiarch_boot_sources.py`	`TestMultiarchBootSources` class with two test methods: `test_architecture_specific_boot_source_resources` validates architecture-specific boot source resources exist across architectures; `test_pointer_datasources` validates architecture-agnostic pointer DataSources reference architecture-specific resources.
Multi-Arch Metrics Tests `tests/install_upgrade_operators/hco_enablement_golden_image_updates/multiarch/test_multiarch_golden_image_metrics.py`	`TestMultiarchGoldenImageAnnotationMetrics` class tests misconfiguration metrics when golden image annotations are unsupported or missing. `TestMultiarchDisabledGoldenImages` class tests resource presence, absence, and metric behavior when multi-arch support is disabled or restricted by nodePlacement.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

The PR introduces two substantial test modules with six test methods across two classes (metrics) and two test methods in one class (boot sources), each with descriptive docstrings and marks. While the test patterns are homogeneous and straightforward, the reviewer must validate test scope, assertions, and logical correctness across multiple independent test scenarios covering enabled/disabled multi-arch states and resource validation.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is largely incomplete, with only the short description field minimally filled and most required sections left empty or missing substantive content.	Complete the description template: explain what the new test modules do, why they're needed, which issues they address, and provide any special review notes beyond just the Jira ticket.
Title check	❓ Inconclusive	The title 'IUO: Multiarch STD' is vague and uses unexplained abbreviations without conveying what changes were actually made.	Clarify the title with what was actually implemented. Example: 'Add multiarch boot sources and golden image metrics tests' would be more descriptive.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-virtualization-qe-bot · 2026-05-06T15:28:18Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest verify-bugs-are-open - verify-bugs-are-open
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

dshchedr
myakove
rnetser
vsibirsk

Reviewers:

OhadRevah
RoniKishner
albarker-rh
dshchedr
hmeir
rlobillo
rnetser
vsibirsk

Available Labels

hold
verified
wip
lgtm
approve

AI Features

Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

dshchedr · 2026-05-07T22:54:53Z

+        - Multi-arch golden images support enabled
+    """
+
+    @pytest.mark.polarion("CNV-XXXXX")


if it is a WIP pr - pls mark it accordingly

vsibirsk · 2026-05-08T14:32:16Z

+    and correctness on a heterogeneous cluster.
+
+    Preconditions:
+        - Multi-arch golden images support enabled


shouldn't it be more detailed in STD?

vsibirsk · 2026-05-08T14:36:18Z

+
+Preconditions:
+    - Multi-architecture cluster with AMD64 and ARM64 worker nodes
+    - Golden images namespace exists


when won't it exist?

vsibirsk · 2026-05-08T14:47:06Z

+    """
+
+    @pytest.mark.polarion("CNV-XXXXX")
+    def test_architecture_specific_boot_source_resources(self):


don't we have these tests in regression?

IUO: Multiarch STD

e354d4e

Signed-off-by: Harel Meir <hmeir@redhat.com>

github-actions Bot added the sig-iuo label May 6, 2026

openshift-virtualization-qe-bot requested a review from RoniKishner May 6, 2026 15:28

openshift-virtualization-qe-bot assigned hmeir May 6, 2026

openshift-virtualization-qe-bot requested a review from albarker-rh May 6, 2026 15:28

openshift-virtualization-qe-bot mentioned this pull request May 6, 2026

IUO: Multiarch STD - 4763 #4764

Open

openshift-virtualization-qe-bot added branch-main needs-rebase labels May 6, 2026

openshift-virtualization-qe-bot requested a review from vsibirsk May 6, 2026 15:28

openshift-virtualization-qe-bot added the size/L label May 6, 2026

openshift-virtualization-qe-bot requested review from OhadRevah, dshchedr, rlobillo and rnetser May 6, 2026 15:28

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing labels May 6, 2026

dshchedr reviewed May 7, 2026

View reviewed changes

openshift-virtualization-qe-bot-2 added the commented-dshchedr label May 7, 2026

vsibirsk reviewed May 8, 2026

View reviewed changes

openshift-virtualization-qe-bot-3 added the commented-vsibirsk label May 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IUO: Multiarch STD#4763

IUO: Multiarch STD#4763
hmeir wants to merge 1 commit intoRedHatQE:mainfrom
hmeir:multiarch-std

hmeir commented May 6, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 6, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

openshift-virtualization-qe-bot commented May 6, 2026

Uh oh!

dshchedr May 7, 2026

Uh oh!

vsibirsk May 8, 2026

Uh oh!

vsibirsk May 8, 2026

Uh oh!

vsibirsk May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

hmeir commented May 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Short description:

More details:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

openshift-virtualization-qe-bot commented May 6, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

dshchedr May 7, 2026

Choose a reason for hiding this comment

Uh oh!

vsibirsk May 8, 2026

Choose a reason for hiding this comment

Uh oh!

vsibirsk May 8, 2026

Choose a reason for hiding this comment

Uh oh!

vsibirsk May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hmeir commented May 6, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 6, 2026 •

edited

Loading