Conversation
This reverts commit 32ba973.
- Renamed `getSongUri` to `getOnlinePlaySongUri` and updated it to construct a direct server URL string instead of using Retrofit. - Renamed `getSongUris` to `getDownloadBatchSongUris` and updated it to return manually constructed `SongUrlV1Data` objects with direct server URLs. - Integrated `DataStoreManager` to fetch the server domain dynamically. - Updated call sites in `DownloadWorker` and `DataSource` to reflect the new method names.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3001af8d1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| Log.d("RedirectingDataSource", "Redirecting URI: ${dataSpec.uri} to $currentUri") | ||
|
|
||
| val redirectedSpec = dataSpec.buildUpon().setUri(currentUri!!).build() |
There was a problem hiding this comment.
RedirectingDataSource.open only assigns currentUri when the incoming URI matches the custom redefinencm://playbackPlaceHolder shape, but it unconditionally calls currentUri!! afterward. Any non-placeholder media item URI (for example, a direct http/file/content item from another controller path) will hit this code path and crash playback with an NPE instead of falling back to the original URI.
Useful? React with 👍 / 👎.
| return songIds.map { id -> | ||
| SongUrlV1Data( | ||
| id = id, | ||
| url = "${runBlocking { DataStoreManager.getStringItem("server", "http://ncm.tryagain.icu/") }}song/url/v1/302?id=$id&level=${SettingProvider.downloadQuality}", |
There was a problem hiding this comment.
This now builds download URLs as /song/url/v1/302?..., but DownloadWorker.enqueueDownload derives the saved extension from uri.lastPathSegment; for these URLs the segment is always 302, so files are saved as <songId>.302. That produces non-audio filenames and breaks compatibility with external players/scanners that rely on standard audio extensions.
Useful? React with 👍 / 👎.
1 participant
No description provided.