Skip to content

Removed and refactored GH Actions - #29

Merged
Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
Arctis-Fireblight:refactor-gha
May 20, 2026
Merged

Removed and refactored GH Actions#29
Arctis-Fireblight merged 1 commit into
Redot-Engine:masterfrom
Arctis-Fireblight:refactor-gha

Conversation

@Arctis-Fireblight

@Arctis-Fireblight Arctis-Fireblight commented May 20, 2026

Copy link
Copy Markdown
Contributor
  • Updated the GHA to reflect that deployment is handled by our own infrastructure instead of Cloudflare Workers now.
  • Fixed the automatic PR generation to reflect that the class docs are not prefixed with class_.
  • Updated node from 20 to 24 because it is deprecated.

Summary by CodeRabbit

  • Chores
    • Updated Node.js runtime to version 24 across Docker and CI/CD pipelines.
    • Refined documentation generation process with improved file management in automated workflows.
    • Updated project ignore patterns for build artifacts.

Review Change Stack

- Updated the GHA to reflect that deployment is handled by our own infrastructure instead of Cloudflare Workers now.
- Fixed the automatic PR generation to reflect that the class docs are not prefixed with `class_`.
- Updated node from 20 to 24 because it is deprecated.
@Arctis-Fireblight Arctis-Fireblight self-assigned this May 20, 2026
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8d3ecd61-22da-4d90-8add-bad676412e29

📥 Commits

Reviewing files that changed from the base of the PR and between dca9e18 and 0fdd517.

📒 Files selected for processing (5)
  • .github/workflows/deploy.yml
  • .github/workflows/pr-build.yml
  • .github/workflows/sync_class_ref.yml
  • .gitignore
  • Dockerfile
💤 Files with no reviewable changes (1)
  • .github/workflows/deploy.yml

📝 Walkthrough

Walkthrough

Node.js is upgraded from version 20 to 24 across Docker and CI builds. The class reference documentation sync workflow is refined to remove event-based dispatch triggers and improve file exclusion logic. Build artifacts are added to gitignore.

Changes

Infrastructure and CI/CD Configuration Updates

Layer / File(s) Summary
Node.js runtime version upgrade to 24
Dockerfile, .github/workflows/pr-build.yml
Docker base image and GitHub Actions setup-node action both upgrade from Node.js 20 to Node.js 24.
Class reference documentation synchronization workflow refinement
.github/workflows/sync_class_ref.yml
Repository dispatch trigger (sync_class_ref event) is removed, leaving only workflow_dispatch and cron schedule as triggers. Documentation deletion logic changes from glob pattern removal to a bash loop that iterates docs/Classes/*.md and excludes index.md via an exclusion list.
Build artifact directory ignore configuration
.gitignore
The .junie/ directory is added to .gitignore.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Redot-Engine/redot-docs-site#12: Both PRs modify GitHub Actions CI workflows—pr-build.yml Node version updates and deploy.yml configuration changes.
  • Redot-Engine/redot-docs-site#9: This PR adds the Cloudflare Pages deployment workflow, while the current PR removes it alongside Node.js/Docker version upgrades.
  • Redot-Engine/redot-docs-site#8: Both PRs modify the sync_class_ref.yml workflow, with the current PR changing its trigger mechanism and improving documentation cleanup logic.

Poem

🐰 Hop along, Node 24 arrives with speed,
Old dispatch triggers fade, new workflows freed,
Docs cleaned with care, .junie tucked away,
Infrastructure blooms in the rabbit's new day!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Removed and refactored GH Actions' is vague and overly generic. While it refers to changes in GitHub Actions, it does not specify the key objective: removing Cloudflare deployment and updating Node.js versions. Consider a more descriptive title such as 'Remove Cloudflare deployment and update Node.js to v24' or 'Refactor GH Actions: remove Cloudflare, update Node.js, fix class docs prefix'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Arctis-Fireblight
Arctis-Fireblight merged commit 81d53ba into Redot-Engine:master May 20, 2026
2 checks passed
@Arctis-Fireblight
Arctis-Fireblight deleted the refactor-gha branch May 20, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant