Gave Pump Scheduling problems more accuracy at the cost of more computation time#350
Merged
Conversation
wrigjl
approved these changes
Jul 4, 2026
wrigjl
left a comment
Collaborator
There was a problem hiding this comment.
Check out the comment above on infinity handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
const int Buckets = 1000 — always 1000 buckets regardless of tank size
bucketSize = cap / 1000 — each bucket represented a fraction of capacity
After:
buckets = (int)Math.Ceiling(cap) — number of buckets equals the tank capacity (in gallons)
bucketSize = 1.0 — each bucket represents exactly 1 gallon
The effect is that tank levels are now tracked at 1-gallon precision instead of cap/1000 precision. For the default 10,000-gallon tank this makes buckets 10× finer (10,000 vs 1,000), but the real benefit is correctness — the bucket count now scales with the actual tank size rather than being an arbitrary constant. The change appears in both the CM and EM solvers, and in two separate DP methods within the EM solver.