Skip to content

Rename SSSP to SPSP - correct problem classification#362

Merged
wrigjl merged 1 commit into
ReduxISU:CSharpAPIfrom
RajNilkar:feature/spsp-problem
Jul 9, 2026
Merged

Rename SSSP to SPSP - correct problem classification#362
wrigjl merged 1 commit into
ReduxISU:CSharpAPIfrom
RajNilkar:feature/spsp-problem

Conversation

@RajNilkar

Copy link
Copy Markdown
Contributor

Summary

This PR renames the recently merged P_SSSP problem to P_SPSP (Single Pair Shortest Path) to correctly reflect what the implementation actually solves.

The Mistake

After the P_SSSP PR was merged, I realized the implementation incorrectly used the SSSP (Single Source Shortest Path) name for what is actually a Single Pair Shortest Path (SPSP) problem. The distinction is:

  • SPSP (what was implemented): Given a weighted graph G, source vertex s, and target vertex t, find the shortest path from s to t. The instance format includes both a source and a target: ({nodes}, {edges}, s, t)
  • SSSP (what the name implied): Given a weighted graph G and source vertex s only, find the shortest paths from s to every other vertex in the graph. No target node. The certificate would be a full distance table, not a single path.

What Changed

Purely a rename — no logic changes whatsoever:

  • Folder: P_SSSPP_SPSP
  • Namespace: API.Problems.P.P_SSSPAPI.Problems.P.P_SPSP
  • Class names: SSSPSPSP, SSSPSolverSPSPSolver, etc.
  • Problem/formal definitions updated to correctly describe SPSP
  • Test file and class names updated
  • All existing tests pass with no changes to logic

Future Work

A separate PR will follow implementing true SSSP correctly:

  • Instance format: ({nodes}, {edges}, s) — no target node
  • Certificate: full distance table from s to all reachable vertices
  • Verifier: validates the complete distance table
  • Graph visualization: shortest path tree (all edges used in shortest paths from s)
  • Table visualization: already works for SPSP, with minor modifications coming soon

@wrigjl wrigjl merged commit 82c6ce1 into ReduxISU:CSharpAPI Jul 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants