Rename SSSP to SPSP - correct problem classification#362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the recently merged
P_SSSPproblem toP_SPSP(Single Pair Shortest Path) to correctly reflect what the implementation actually solves.The Mistake
After the
P_SSSPPR was merged, I realized the implementation incorrectly used the SSSP (Single Source Shortest Path) name for what is actually a Single Pair Shortest Path (SPSP) problem. The distinction is:s, and target vertext, find the shortest path fromstot. The instance format includes both a source and a target:({nodes}, {edges}, s, t)sonly, find the shortest paths fromsto every other vertex in the graph. No target node. The certificate would be a full distance table, not a single path.What Changed
Purely a rename — no logic changes whatsoever:
P_SSSP→P_SPSPAPI.Problems.P.P_SSSP→API.Problems.P.P_SPSPSSSP→SPSP,SSSPSolver→SPSPSolver, etc.Future Work
A separate PR will follow implementing true SSSP correctly:
({nodes}, {edges}, s)— no target nodesto all reachable verticess)