fix: remove empty try/catch in ProblemRowReact (code-scanning #78)#135
Open
wrigjl wants to merge 1 commit into
Open
fix: remove empty try/catch in ProblemRowReact (code-scanning #78)#135wrigjl wants to merge 1 commit into
wrigjl wants to merge 1 commit into
Conversation
…U#78) The try block in handleChangeInstance was empty -- no statements that could throw -- so the catch existed only to handle an error that could never occur. Removed both; setProblemLocalInstance runs unconditionally as it did before. Fixes js/no-empty alert flagged at components/pageblocks/ProblemRowReact.js:137-138. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes a dead empty
try {} catch (error) { ... }block inhandleChangeInstance(components/pageblocks/ProblemRowReact.js). Thetryhad no statements inside it, so thecatchcould never actually run — it wasn't guarding anything.Which scan instance this fixes
Resolves code-scanning alert #78 —
no-empty(Disallow empty block statements), flagged atcomponents/pageblocks/ProblemRowReact.js:137-138.Notes
The
storedDatavariable a few lines above is also hardcoded tonull, suggesting some localStorage read/write logic in this area was stripped out previously and this empty try/catch was left behind as a vestige. LeftstoredDataalone since it's out of scope for this alert — flagging here in case it's worth a follow-up cleanup.No behavior change:
setProblemLocalInstance(event.target.value)and the rest of the handler still run exactly as before.🤖 Generated with Claude Code