docs: separate ADR decisions from implementation specifications - #200
Merged
Conversation
Reefact
force-pushed
the
agent/refactor-adr-specifications
branch
from
July 19, 2026 22:27
ef787af to
3b93909
Compare
Rebased onto main after PR #199 merged a substantive rewrite of this ADR's decision content; folds that content into the editorial trim so neither PR's work is lost.
PR #201 merged and claimed ADR-0023 (keep expression-tree selectors for the v1 binder API) while this branch was still open with its own ADR-0023 (the one-time editorial-refactoring exception). Renumbers the latter to ADR-0024 and updates every cross-reference so no two records share a number.
Reefact
force-pushed
the
agent/refactor-adr-specifications
branch
from
July 19, 2026 22:37
3b93909 to
7d74b82
Compare
Reefact
marked this pull request as ready for review
July 19, 2026 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separates ADR decisions from their implementation mechanics: 13 accepted ADRs are trimmed to context/decision/rationale/alternatives/consequences/risks, the extracted mechanics move into a new bilingual ADR implementation reference, and ADR-0024 records the maintainer-authorized exception that permits this one-time editorial migration.
Type of change
Changes
Testing
dotnet build FirstClassErrors.slndotnet test FirstClassErrors.slnFirstClassErrors.Analyzers.UnitTests) — covered by the full-solution test run aboveDocumentation
doc/updateddoc/handwritten/for-users/README.fr.md) updated if user-facing behavior changed — not touched by this PR; the French ADR translations underdoc/handwritten/for-maintainers/adr/were kept in sync insteadArchitecture decisions
ADR-0024 is recorded directly as
Acceptedrather than the default agent-draftedProposed, and ADR-0008/0011/0013/0015/0021 are corrected fromProposedtoAccepted, because the maintainer explicitly reviewed and authorized both the migration and the status corrections beforehand (see ADR-0024's Context) — not a unilateral status flip by an agent.Related issues
None.