PR4: rendering, exhibits, cost transparency#5
Open
Regantih wants to merge 6 commits into
Open
Conversation
Owner
Author
ℹ️ Context: superseded by PR #7 for backend; frontend still valuableThis PR (PR4: rendering, exhibits, cost transparency, branch What changed
Recommended actionOnce PR #7 merges to
This PR's content is not superseded — the design system and rendering work will be needed for the memo UI. It just needs to land after PR #7. Do not close this PR — plan to re-target after PR #7 merges. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR4: Rendering, Exhibits, Cost Transparency
Frontend-only. No auth, Stripe, or backend changes. No fake data.
What changed
1 ·
styles/tokens.css— Design token foundation:roottoken set: colours, spacing (4-pt scale), type scale, border radii, shadows, z-index, layout container widths--ink,--paper,--accent,--mute,--rule,--card) so all existing inline CSS continues working without a big-bang refactorfocus-visiblering using--color-accentapplied to all interactive elements2 ·
build.json— Build manifest{ version, commit, branch, built_at }file; CI or the agent overwritescommiton each pushv0.5.0 · 932ddb7; fails silently if the file is absent3 ·
deal.html— Major rewriteIntersectionObserverdrives the active-section highlight as you scroll; collapses to a horizontal scroll strip on mobile (<960 px)<section>hasid,aria-labelledby,scroll-margin-top(accounts for sticky header); headings link back to themselves (#fragment) with a#indicator on hoverdeal.cost.{tokens_in, tokens_out, model, usd_cost, duration_ms, run_id}falling back to top-level equivalents; renders a compact token/cost grid; shows"Cost data not yet available."if all fields absent — no fake numbersdeal.deck,deal.dataroom,deal.model(file link), anddeal.exhibits[]; shows"No exhibits attached yet."when all empty; all links opentarget="_blank" rel="noopener noreferrer"@media print): hides header, TOC, cost panel, agent tags; full-width single column;break-inside:avoidper section; 0.5pt borders--font-seriffor body/headings,--font-monofor kickers/metadata,--font-sansfor UI chrome4 · Global app shell — all pages
Consistent header + footer replaces the 5 different ad-hoc headers that were on each page:
index.htmldeals.htmlsubmit.htmlpipeline.htmldeal.htmlsettings.htmlopacity:.45,pointer-events:none,aria-disabled)build-metaspan populated frombuild.json5 ·
settings.html— Stub page6 · Accessibility
focus-visibleoutlines using--color-accent(#8b6f3d) on all interactive elementsaria-current="page"on active nav linkrole="banner",role="main",role="navigation",role="contentinfo",role="region"on cost/exhibits panelsaria-live="polite"on memo container (for async load)aria-labelon icon-only elements (brand-logo, exhibit links)Files changed
styles/tokens.cssbuild.jsonsettings.htmldeal.htmldeals.htmlpipeline.htmlsubmit.htmlindex.htmlPLAN.mdAcceptance checklist
deal.html?id=pqc-bankrenders all 14 sections with a sticky left TOC#anchor indicator on hovercost.tokens_in,cost.usd_cost,cost.modeletc. is provided, cost grid rendersdeckordataroomURLs is provided, exhibit links renderCtrl+P) hides sidebar/header/cost panel; shows full-width content<960px): TOC collapses to horizontal scroll strip above articlev0.5.0 · 932ddb7frombuild.jsonScreenshot-worthy notes