Directive should not create a new scope#65
Open
Leward wants to merge 3 commits intoReklino:masterfrom
Open
Conversation
|
👍 |
|
Are there plans to roll this under a version number? I've had to do nasty things with npm as this isn't commit is under HEAD rather than a tagged version. |
|
👍 |
src/angular-resizable.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| angular.module('angularResizable', []) | |||
| .directive('resizable', function() { | |||
| .directive('resizable', function($parse) { | |||
There was a problem hiding this comment.
Hi, consider an array literal here to include the '$parse' dependency as a string. Minifying the js can/will end up in the injector not being able to resolve the dependency. Thanks!
There was a problem hiding this comment.
Besides, not adding the dependency as string also makes it break if using strict mode.
Author
|
I applied @laura-lungoci remark and rebased on the master branch. |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the follwing issue:
Error: [$compile:multidir] Multiple directives asking for new/isolated scope #49