0.1.20 - Добавил поддержку Encodable для request в виде функции makeJsonRequestEncodable#8
Open
rentateam-vmedvedev wants to merge 5 commits intoRentateam:masterfrom
Open
Conversation
added 5 commits
December 22, 2021 16:50
a-25
reviewed
Dec 23, 2021
| } | ||
| } | ||
|
|
||
| private func getHeadersWithAuthTokenIfNeeded(request: RequestProtocol) -> HTTPHeaders { |
Contributor
There was a problem hiding this comment.
Может, тогда просто добавить реализацию RequestProtocol: RequestProtocolEncodable, и тогда не нужен будет этот метод? Просто обойдемся generic-ами.
Кстати, тогда, возможно и public func makeJsonRequestEncodable<Foo: RequestProtocolEncodable, Bar: Decodable> станет ненужным.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ранее в request можно было передавать параметры только с помощью типа Parameters (который является словарем [String: Any])
Теперь можно передавать параметры с помощью любого типа данных, который конформит протокол Encodable.
Это избавляет нас от необходимости в ручную заполнять Parameters в стиле:
Теперь мы можем сделать так: