fix: match sink-sql flag typo for --on-module-hash-mistmatch#5
fix: match sink-sql flag typo for --on-module-hash-mistmatch#5rodrigopavezi merged 2 commits intomainfrom
Conversation
The substreams-sink-sql v4.12.0 binary registers the flag as --on-module-hash-mistmatch (with an extra 't'). Passing the correctly spelled --on-module-hash-mismatch causes an "unknown flag" error, making the sink crash-loop on stage.
Greptile SummaryThis PR fixes a crash-loop caused by passing Confidence Score: 5/5Safe to merge — the fix is minimal, the binary is pinned to v4.12.0 where the typo exists, and all version bumps are consistent. No P0 or P1 issues found. The flag name change is intentional and correct for the pinned binary version. Version bumps are consistent across all three files. No files require special attention. When Important Files Changed
Sequence DiagramsequenceDiagram
participant Docker as Docker Entrypoint
participant Setup as substreams-sink-sql setup
participant Run as substreams-sink-sql run
participant DB as PostgreSQL
Docker->>Setup: setup "$DSN" "$SPKG" || true
Setup->>DB: Initialize schema
Docker->>Run: run --on-module-hash-mistmatch=${ON_MODULE_HASH_MISMATCH:-warn} "$DSN" "$SPKG"
Note over Run: Flag matches v4.12.0 binary's registered name (intentional typo)
Run->>DB: Stream & persist events
Reviews (2): Last reviewed commit: "chore: bump version to v0.1.1" | Re-trigger Greptile |
Summary
substreams-sink-sqlv4.12.0 binary has a typo in its flag name: it registers--on-module-hash-mistmatch(extrat) instead of--on-module-hash-mismatchunknown flagerror and a crash-loop on stageTest plan
unknown flag: --on-module-hash-mismatcherror