-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Fix token structure documentation #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add missing fields: id, network, type, hash - Remove non-existent logoURI field - Add field descriptions table - Link to SDK source for supported networks and types Fixes #7 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughDocumentation updates to clarify token schema requirements and supported configuration options. CONTRIBUTING.md expanded with field descriptions, supported networks, and currency types guidance. README.md updated with realistic USDC token example and link to contribution guidelines. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes incomplete and inaccurate token structure documentation in README.md and CONTRIBUTING.md. The updates add all previously missing required fields ( Key improvements:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Docs as Documentation
participant Repo as Token List Repo
participant SDK as Request Network SDK
Note over Dev,SDK: Documentation Fix Process
Dev->>Docs: Identifies incomplete token structure
Note over Docs: Missing: id, network, type, hash<br/>Incorrect: logoURI field
Dev->>Repo: Reads actual token-list.json
Repo-->>Dev: Returns real USDC token structure
Note over Dev: Verifies all 9 required fields
Dev->>SDK: References currency-types.ts
SDK-->>Dev: Supported network values
Dev->>SDK: References request-logic-types.ts
SDK-->>Dev: Supported currency type values
Dev->>SDK: References getHash.ts
SDK-->>Dev: Hash calculation for native tokens
Dev->>Docs: Updates README.md
Note over Docs: Adds complete USDC example<br/>Links to CONTRIBUTING.md
Dev->>Docs: Updates CONTRIBUTING.md
Note over Docs: Adds field descriptions table<br/>Documents supported values<br/>Links to SDK source
Docs-->>Dev: Complete & accurate documentation
|
Problem
README and CONTRIBUTING.md have incomplete/incorrect token structure documentation:
id,network,type,hashlogoURIFixes #7
Proposed Solution
Updated both README.md and CONTRIBUTING.md with:
networkandtypevalueshashfield (same as address for ERC20, calculated for native tokens)Considerations
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.