Skip to content

CU-868ex18rd Locking macos build agent version#61

Merged
ucswift merged 1 commit into
masterfrom
develop
Aug 22, 2025
Merged

CU-868ex18rd Locking macos build agent version#61
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented Aug 22, 2025

Summary by CodeRabbit

  • Chores
    • Updated the iOS build environment in CI to use macOS 14, aligning with current Apple tooling and ensuring compatibility with the latest runners.
    • Maintains existing build and deploy logic; only the underlying runner version changes.
    • No impact on app features or user experience; this is an infrastructure update aimed at build consistency and reliability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 22, 2025

Walkthrough

Updated the GitHub Actions workflow to use macos-14 instead of macos-latest for iOS builds within the matrix runs-on condition. The conditional selection between macOS for iOS and ubuntu-latest for other platforms remains unchanged. No other workflow logic was modified.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/react-native-cicd.yml
Updated runner image for iOS builds from macos-latest to macos-14 within matrix-based runs-on; no other logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hop through YAML, swift and light,
From “latest” skies to “14” bright.
A macOS moon for builds that fly,
Carrots compiled, CI on high.
Thump-thump—deploy, then say good night. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/react-native-cicd.yml (1)

153-160: jq installation fallback will fail on macOS runners (no apt-get).

If jq isn’t present on macOS, this step will attempt apt-get and error. Use RUNNER_OS to branch to brew on macOS and apt-get on Linux.

Apply this diff:

-          # Check if jq is installed, if not install it
-          if ! command -v jq &> /dev/null; then
-            echo "Installing jq..."
-            sudo apt-get update && sudo apt-get install -y jq
-          fi
+          # Ensure jq is available on both Linux and macOS
+          if ! command -v jq &> /dev/null; then
+            echo "Installing jq..."
+            if [ "${RUNNER_OS}" = "Linux" ]; then
+              sudo apt-get update && sudo apt-get install -y jq
+            elif [ "${RUNNER_OS}" = "macOS" ]; then
+              brew update || true
+              brew install jq
+            else
+              echo "Unsupported runner OS: ${RUNNER_OS}" >&2
+              exit 1
+            fi
+          fi
🧹 Nitpick comments (3)
.github/workflows/react-native-cicd.yml (3)

116-116: Good call pinning iOS to macos-14 to avoid surprise image/Xcode rollovers.

This stabilizes runner tooling for iOS builds. Two small follow-ups:

  • Consider asserting the Xcode toolchain at runtime so failures are fast and explicit.
  • Consider mapping platform→runner via matrix include for readability.

Example additions (outside this line range):

# Verify Xcode version early (optional)
- name: 🔎 Verify Xcode toolchain
  if: matrix.platform == 'ios'
  run: |
    xcodebuild -version
    swift --version

Alternative matrix mapping (readability):

strategy:
  matrix:
    include:
      - platform: ios
        os: macos-14
      - platform: android
        os: ubuntu-latest
runs-on: ${{ matrix.os }}

129-133: You’ve pinned the runner, but EAS/Expo remain unpinned (latest).

This undercuts reproducibility benefits from the macOS pin. Recommend pinning to a known-good EAS CLI version your team validated and updating deliberately.

Proposed change (adjust version to your known-good):

with:
  expo-version: 51.x  # or your validated Expo CLI version
  eas-version: 11.12.0  # example; pin to a version you’ve tested
  token: ${{ secrets.EXPO_TOKEN }}

95-103: Consider upgrading actions/cache from v3 → v4.

v4 provides improved performance and fixes compared to v3. Safe, low-risk bump that benefits all cached steps.

Suggested change for each usage:

-uses: actions/cache@v3
+uses: actions/cache@v4

Also applies to: 136-144, 178-185, 253-263

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 80f8d20 and c7be7af.

📒 Files selected for processing (1)
  • .github/workflows/react-native-cicd.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test
  • GitHub Check: Analyze (javascript-typescript)

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented Aug 22, 2025

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit 8b1c143 into master Aug 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant