feat(achievement): add Recent Unlocks component#4589
Merged
wescopeland merged 2 commits intoRetroAchievements:masterfrom Feb 23, 2026
Merged
feat(achievement): add Recent Unlocks component#4589wescopeland merged 2 commits intoRetroAchievements:masterfrom
wescopeland merged 2 commits intoRetroAchievements:masterfrom
Conversation
Jamiras
approved these changes
Feb 23, 2026
| const { t } = useTranslation(); | ||
| const { formatDate } = useFormatDate(); | ||
|
|
||
| const placeholderRowCount = Math.min(achievement.unlocksTotal ?? 0, 50); |
Member
There was a problem hiding this comment.
I wonder if it would make sense to restrict this to a smaller number (maybe 10?). I'm not sure how players would use this information other than to ask a recent earner how they did it.
Conversely, it would be nice to have a "more..." link.
Member
Author
There was a problem hiding this comment.
I had a similar thought - I kept it at 50 because I wasn't sure if there was some downstream consumer of this data (ie: events) that we're not aware of.
Some sort of more link does make sense (or maybe pagination of the existing list). I'll add this to my notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR populates the "Recent Unlocks" tab in
achievement2. The implementation is fairly straightforward and almost identical to the existing PHP UI with a few subtle changes:http://localhost:64000/achievement2/9?tab=unlocks