Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Add @lavamoat/allow-scripts setup#33

Open
naugtur wants to merge 2 commits intomasterfrom
naugtur/lavamoat-allow-scripts
Open

Add @lavamoat/allow-scripts setup#33
naugtur wants to merge 2 commits intomasterfrom
naugtur/lavamoat-allow-scripts

Conversation

@naugtur
Copy link
Copy Markdown

@naugtur naugtur commented Apr 13, 2024

TODO:

  • discuss whether web-ext>bunyan>dtrace-provider is needed
  • check if esbuild can work without scripts... wait - esbuild doesn't seem to be used. Does tsx use it now?

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/aa@4.2.0 None 0 19.8 kB boneskull
npm/@lavamoat/allow-scripts@3.0.4 environment 0 45.8 kB boneskull
npm/@lavamoat/preinstall-always-fail@2.0.0 None 0 3.25 kB naugtur
npm/@npmcli/agent@2.2.2 environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/fs@3.1.0 filesystem 0 26.5 kB lukekarrys
npm/@npmcli/git@5.0.5 filesystem 0 21.8 kB npm-cli-ops
npm/@npmcli/node-gyp@3.0.0 filesystem 0 1.87 kB lukekarrys
npm/@npmcli/package-json@5.0.2 filesystem 0 37.4 kB npm-cli-ops
npm/@npmcli/promise-spawn@7.0.1 environment, shell 0 12 kB npm-cli-ops
npm/@npmcli/run-script@7.0.4 environment 0 18.4 kB npm-cli-ops
npm/abbrev@2.0.0 None 0 4.83 kB lukekarrys
npm/agent-base@7.1.1 network 0 31.2 kB tootallnate
npm/bin-links@4.0.3 filesystem 0 20.6 kB npm-cli-ops
npm/builtins@5.1.0 None 0 3.7 kB juliangruber
npm/cacache@18.0.2 filesystem 0 63.6 kB npm-cli-ops
npm/chownr@2.0.0 filesystem 0 5.75 kB isaacs
npm/cmd-shim@6.0.2 filesystem 0 12.1 kB npm-cli-ops
npm/color-support@1.1.3 None 0 9.23 kB isaacs
npm/console-control-strings@1.1.0 None 0 12.7 kB iarna
npm/encoding@0.1.13 None 0 7.12 kB andris
npm/env-paths@2.2.1 None 0 10.2 kB sindresorhus
npm/err-code@2.0.3 None 0 12.3 kB achingbrain
npm/exponential-backoff@3.1.1 None 0 37.3 kB sssayegh
npm/fs-minipass@3.0.3 filesystem 0 14.4 kB npm-cli-ops
npm/has-unicode@2.0.1 environment 0 3.44 kB iarna
npm/hosted-git-info@7.0.1 None 0 26.7 kB npm-cli-ops
npm/http-proxy-agent@7.0.2 network 0 23.3 kB tootallnate
npm/https-proxy-agent@7.0.4 network 0 35.3 kB tootallnate
npm/iconv-lite@0.6.3 None 0 349 kB ashtuchkin
npm/infer-owner@1.0.4 filesystem 0 4.29 kB isaacs
npm/ip-address@9.0.5 None 0 177 kB beaugunderson
npm/ip@2.0.0 None 0 13.6 kB indutny
npm/is-lambda@1.0.1 None 0 2.94 kB watson
npm/jsbn@1.1.0 None 0 46.9 kB andyperlitch
npm/json-parse-even-better-errors@3.0.1 None 0 9.87 kB npm-cli-ops
npm/make-fetch-happen@13.0.0 network 0 52.5 kB npm-cli-ops
npm/minipass-collect@2.0.1 None 0 4.96 kB isaacs
npm/minipass-fetch@3.0.4 environment, network 0 46.8 kB npm-cli-ops
npm/minipass-flush@1.0.5 None 0 3.77 kB isaacs
npm/minipass-pipeline@1.2.4 None +1 55.1 kB isaacs
npm/minipass-sized@1.0.3 None 0 124 kB isaacs
npm/minizlib@2.1.2 None 0 17.3 kB isaacs
npm/negotiator@0.6.3 None 0 27.4 kB dougwilson
npm/node-gyp@10.1.0 environment, shell +1 2.19 MB lukekarrys
npm/nopt@7.2.0 None 0 26.1 kB npm-cli-ops
npm/normalize-package-data@6.0.0 None 0 28.3 kB npm-cli-ops
npm/npm-install-checks@6.3.0 None 0 6.21 kB npm-cli-ops
npm/npm-normalize-package-bin@3.0.1 None 0 3.58 kB npm-cli-ops
npm/npm-package-arg@11.0.1 None 0 19.1 kB npm-cli-ops
npm/npm-pick-manifest@9.0.0 None 0 16.4 kB npm-cli-ops
npm/p-map@4.0.0 None 0 8.69 kB sindresorhus
npm/proc-log@3.0.0 None 0 5.21 kB lukekarrys
npm/promise-inflight@1.0.1 None 0 3.04 kB iarna
npm/promise-retry@2.0.1 None 0 15.6 kB achingbrain
npm/read-cmd-shim@4.0.0 filesystem 0 5.16 kB lukekarrys
npm/retry@0.12.0 None 0 32.2 kB tim-kos
npm/set-blocking@2.0.0 None 0 4.22 kB bcoe
npm/smart-buffer@4.2.0 None 0 138 kB joshglazebrook
npm/socks-proxy-agent@8.0.3 network 0 25.1 kB tootallnate
npm/socks@2.8.3 network 0 156 kB joshglazebrook
npm/split2@4.2.0 None 0 17.4 kB matteo.collina
npm/sprintf-js@1.1.3 None 0 39.9 kB alexei
npm/ssri@10.0.5 None 0 38.7 kB npm-cli-ops
npm/tar@6.2.1 environment, filesystem +2 250 kB isaacs
npm/unique-filename@3.0.0 None 0 3.41 kB lukekarrys
npm/unique-slug@4.0.0 None 0 2.58 kB lukekarrys
npm/validate-npm-package-name@5.0.0 None 0 7.88 kB lukekarrys
npm/which@4.0.0 environment 0 7.5 kB npm-cli-ops
npm/write-file-atomic@5.0.1 filesystem 0 12.2 kB npm-cli-ops

🚮 Removed packages: npm/@amplitude/analytics-connector@1.4.5, npm/@babel/helper-plugin-utils@7.19.0, npm/@babel/plugin-syntax-jsx@7.18.6, npm/@discoveryjs/json-ext@0.5.7, npm/@jridgewell/source-map@0.3.6, npm/@npmcli/fs@2.1.2, npm/@npmcli/move-file@2.0.1, npm/@types/cacheable-request@6.0.2, npm/@types/json-buffer@3.0.0, npm/@types/keyv@4.2.0, npm/@types/responselike@3.0.0, npm/@webassemblyjs/floating-point-hex-parser@1.11.6, npm/@webassemblyjs/helper-api-error@1.11.6, npm/@webassemblyjs/helper-buffer@1.12.1, npm/@webassemblyjs/helper-wasm-bytecode@1.11.6, npm/@webassemblyjs/helper-wasm-section@1.12.1, npm/@webassemblyjs/ieee754@1.11.6, npm/@webassemblyjs/leb128@1.11.6, npm/@webassemblyjs/utf8@1.11.6, npm/@webassemblyjs/wasm-gen@1.12.1, npm/@webassemblyjs/wasm-opt@1.12.1, npm/@webassemblyjs/wast-printer@1.12.1, npm/@webpack-cli/configtest@1.2.0, npm/@webpack-cli/info@1.5.0, npm/@webpack-cli/serve@1.7.0, npm/abbrev@1.1.1, npm/agent-base@6.0.2, npm/agentkeepalive@4.2.1, npm/are-we-there-yet@3.0.1, npm/async@3.2.5, npm/buffer-crc32@0.2.13, npm/clone-deep@4.0.1, npm/envinfo@7.12.0, npm/fastest-levenshtein@1.0.16, npm/fd-slicer@1.1.0, npm/flat@5.0.2, npm/humanize-ms@1.2.1, npm/immediate@3.0.6, npm/import-local@3.1.0, npm/interpret@2.2.0, npm/is-bigint@1.0.4, npm/is-boolean-object@1.1.2, npm/is-number-object@1.0.7, npm/is-plain-object@2.0.4, npm/jest-worker@27.5.1, npm/jszip@3.10.1, npm/lie@3.3.0, npm/pend@1.2.0, npm/pkg-dir@4.2.0, npm/rechoir@0.7.1, npm/resolve-cwd@3.0.0, npm/rev-hash@3.0.0, npm/shallow-clone@3.0.1, npm/terser@5.30.3, npm/tr46@0.0.3, npm/webidl-conversions@3.0.1, npm/wildcard@2.0.1, npm/xmlbuilder@11.0.1

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 13, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@lavamoat/preinstall-always-fail@2.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@naugtur
Copy link
Copy Markdown
Author

naugtur commented Apr 13, 2024

@SocketSecurity ignore npm/@lavamoat/preinstall-always-fail@2.0.0
it's the whole point of the package

@rkalis
Copy link
Copy Markdown
Member

rkalis commented Jun 7, 2024

Hey, thanks for the PR and apologies for the lack of reply. I looked into the points in your TODOs. As far as I can tell, we should be able to set web-ext>bunyan>dtrace-provider to false.

Re: esbuild, tsx does need esbuild to function, and from what I can see, I don't think we can disable scripts for esbuild. However, we currently only have tsx installed as a devDependency to run some of the TS scripts in the scripts/ directory. e.g. yarn tsx scripts/get-signature.tsx .... So that means we could also remove tsx from the devDependencies and install it globally instead, if you think that'd be a safer option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants