Fix invisible approval requests in dashboard#713
Open
CastleOneX wants to merge 1 commit intoRightNow-AI:mainfrom
Open
Fix invisible approval requests in dashboard#713CastleOneX wants to merge 1 commit intoRightNow-AI:mainfrom
CastleOneX wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Keep a bounded recent approval history instead of dropping timed-out or resolved requests on the floor, return recent approvals from /api/approvals, and make the dashboard poll and badge pending approvals so shell_exec prompts do not disappear before the user ever sees them. (cherry picked from commit 78dd9f99cc835e85e452889bf6cfced5137f8a4a)
jaberjaber23
approved these changes
Mar 19, 2026
Member
jaberjaber23
left a comment
There was a problem hiding this comment.
Well done. ApprovalRecord history with bounded VecDeque, pending badge in nav, toast notifications, 5s polling, expired filter. Tests cover all three decision paths. Clean implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Approval-gated actions such as shell_exec could time out or resolve before the Approvals page was opened. In practice this made requests appear to vanish, which made the security flow feel broken even though the request had existed briefly.
Validation