Closed
Conversation
Member
|
Closing this PR. While the MongoDB backend concept is interesting, this needs discussion before implementation. Issues: unsolicited major feature with no linked issue, adds heavy mongodb dependency (20+ transitive crates), zero tests for 1,904 lines of new code, breaking API changes to MemorySubstrate and UsageStore, session.rs has duplicate match arms that likely won't compile, fire-and-forget audit writes weaken audit trail integrity, auto-generated macOS-schema.json (2,990 lines of noise). If you'd like to pursue MongoDB support, please open an issue first so we can discuss the design and scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity