Skip to content

Added getCookies func#184

Merged
metaprime merged 1 commit into
RipMeApp:masterfrom
cyian-1756:cookie_support
Nov 13, 2017
Merged

Added getCookies func#184
metaprime merged 1 commit into
RipMeApp:masterfrom
cyian-1756:cookie_support

Conversation

@cyian-1756

Copy link
Copy Markdown
Collaborator

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix

Description

I added a util function (Taken from 4pr0n/ripme#354) for getting site cookies from the config file

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@metaprime metaprime left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- we should add a few of these so that there's an example of how to use.

@metaprime metaprime merged commit c1de0ff into RipMeApp:master Nov 13, 2017
@cyian-1756 cyian-1756 deleted the cookie_support branch May 24, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants