Open
Conversation
added 2 commits
December 2, 2020 07:59
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
|
dense.txt Sorry forgot the files ... |
In recent versions of GCC (9.3.0), std::isnan of double returns false even when a nan value is provided, because Ofast enables -ffast-math option See: https://stackoverflow.com/a/47703550/13339777 Apparently, this could also lead to some issues with inf values, but we only use them for comparison, and at the moment we did not encounter any issues Signed-off-by: julian <julian.burellaperez@heig-vd.ch>
|
commit 57fb1e0 fixes an issue I could not observe on my GCC version (7.5.0), but a colleague observed with his more recent GCC version (9.3.0). In colleague case, the behavior observed was to loop indefinitely inside readers for distance type inputs. The culprit found was I updated to not rely on this kind of results and now the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Ulrich,
Playing with
ripserusing datasets where data was pruned using in my casecollapser, I encountered an unexpected behaviour when reading distance matrices whereinfvalues are present in the input file.std::istreamorstd::istringstreamreturns 0 instead ofinfif they encounterINF, Inf, etc.in an input file when you try to directly assign the stream into afloatordoublevariable.Why are
infvalues in this distances matrices ? Because, when pruning data from the original distances matrices, I replace a pruned data byinf.In attachment you'll find a distance matrix not pruned
dense.txt. Its pruned versiondense_pruned.txtand the lower and upper part of thedense_pruned.txtto test the lower and upper reader.Command to test the different datasets:
The expected results is:
Please, feel free to suggest any modifications or if you have any remarks.
Best,
Julián