Skip to content

Fixed resolving project directory - #494

Merged
Ocramius merged 1 commit into
Roave:1.35.xfrom
kukulich:project-directory
Mar 10, 2024
Merged

Fixed resolving project directory#494
Ocramius merged 1 commit into
Roave:1.35.xfrom
kukulich:project-directory

Conversation

@kukulich

@kukulich kukulich commented Mar 10, 2024

Copy link
Copy Markdown
Contributor

It should help with Roave/BetterReflection#1391

  • installed-as-composer-dependency is missing one ..
  • I've changed the resolving order because we need to resolve installed-as-composer-dependency before current-working-directory

Ocramius
Ocramius approved these changes Mar 10, 2024
View reviewed changes

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this 👍

@Ocramius Ocramius self-assigned this Mar 10, 2024
@Ocramius Ocramius added the enhancement New feature or request label Mar 10, 2024
@Ocramius Ocramius added this to the 1.35.0 milestone Mar 10, 2024
@Ocramius
Ocramius merged commit 3cb3284 into Roave:1.35.x Mar 10, 2024
@kukulich
kukulich deleted the project-directory branch March 10, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.35.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kukulich @Ocramius