Update physfs and use SDL physfssdl3 in tests#24
Merged
Conversation
RobLoach
commented
Jun 5, 2026
| add_executable(SDL_PhysFS_Test SDL_PhysFS_Test.c) | ||
| add_executable(SDL_PhysFS_Test | ||
| SDL_PhysFS_Test.c | ||
| ${physfs_SOURCE_DIR}/extras/physfssdl3.c |
Owner
Author
There was a problem hiding this comment.
No, not physfssdl3.c... Use physfs_platform_sdl3.c
RobLoach
marked this pull request as draft
June 5, 2026 21:02
RobLoach
marked this pull request as ready for review
June 6, 2026 03:25
RobLoach
commented
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates physfs to commit 5f73e95 (which includes physfssdl3 and physfs_platform_sdl3), adds physfssdl3.c to the test build, and tests PHYSFSSDL3_openRead and PHYSFSSDL3_makeStorage. Fixes #23