[Medium] Feature/front end 1#12
Conversation
| engine = Engine() | ||
| self._message_handler = MessageHandler() | ||
| self._game_manager = GameManager(game_repo=game_repo, game_engine=engine, front_end=self._message_handler) | ||
| if isinstance(game_id_or_players, list): |
There was a problem hiding this comment.
hmm maybe it can be improved in the future? it is strange to ask for game_id_or_players. Also, to create a new game, we need the game settings
There was a problem hiding this comment.
Yeah it's quite messy but the idea is to throw this away in one month. In a later iteration (with API etc) we will have a specialized route for starting a new game with specific settings but for this one to make it work as fast as possible. The players or gameid is basically saying either load a game or start a new one with the minimal possible info (player names)
| if self.asset.asset_type is AssetType.GENERATOR: | ||
| text = "G" | ||
| elif self.asset.asset_type is AssetType.LOAD: | ||
| text = "I" if self.asset.is_ice_cream else "L" |
There was a problem hiding this comment.
ice cream loads show an L instead of an I when I execute the test, not sure what the problem is.
For instance:
print({asset.id: asset.is_ice_cream for asset in game_state.assets}) prints
{0: False, 1: False, 2: False, 3: True, 4: True, 5: True}
There was a problem hiding this comment.
hmm that is strange, it works well for me, when did you last pull?
| SocketSide = Literal["tr", "bl"] | ||
|
|
||
|
|
||
| class SocketProvider: |
There was a problem hiding this comment.
add a docstring to clarify what tr and bl stand for?
RomanCantu
left a comment
RomanCantu
left a comment
There was a problem hiding this comment.
other than the ice cream assets, it seems to be working correctly. Nice UI
2 participants
Uh oh!
There was an error while loading. Please reload this page.