🐛 Fix diff tracking: hydrate bootstrap + clear stale current_diff#66
Merged
🐛 Fix diff tracking: hydrate bootstrap + clear stale current_diff#66
Conversation
Bootstrap snapshots included diff/turnDiffs/plan data on the wire but handleConversationBootstrap never applied them to the SessionObservable. This caused the review panel to show empty diffs after connect/reconnect. Also clears current_diff on TurnCompleted so it only represents in-progress state, not stale data from the last completed turn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleConversationBootstrapdiscardedcurrent_diff,current_plan,turn_diffs,current_turn_id, andturn_countfrom the server payload becauseSessionDetailSnapshotProjectiondidn't include them. Review panel showed empty diffs after connect/reconnect.current_diff: Server never clearedcurrent_diffafterTurnCompleted, leaving the same diff in bothsessions.current_diffandturn_diffs. Now cleared in transition state, persistence, and emitted viaSessionDelta.Changes
SessionStore+Events.swiftconnector-core/transition.rscurrent_diffafter archiving intoturn_diffs; emit clearing inSessionDelta; updated testpersistence/mod.rssessions.current_diffin DB when inserting turn diffTest plan
make rust-ci)make test-unit)current_diffclears in real-time on the review panelCloses #62