Refactor SDK types and add CreateViewRequest support#72
Merged
Conversation
## Summary This update refines the SDK by removing unused types and introducing a new `CreateViewRequest` type, enhancing the overall structure and usability of the SDK. ## Changes Made - **Removed Types**: Eliminated the `PlaidConnectionConfig` type and related definitions to streamline the SDK. - **Updated Types**: Modified `ConnectionProviderInfo` and `ConnectionResponse` to remove references to the `plaid` provider, reflecting current integration capabilities. - **New Type Added**: Introduced `CreateViewRequest` to facilitate view creation with detailed configuration options. ## Key Benefits - **Improved Clarity**: The removal of unused types and the addition of structured request types enhance the SDK's clarity and maintainability. - **Enhanced Functionality**: The new `CreateViewRequest` type provides developers with a clear interface for creating views, improving integration capabilities. ## Breaking Changes - The removal of `PlaidConnectionConfig` may affect consumers relying on this type; ensure to update any related implementations. ## Testing Notes for Reviewers - Verify that the SDK compiles without errors and that the new `CreateViewRequest` type integrates correctly into existing workflows. - Ensure that all references to removed types are eliminated from the codebase. ## Technical Impact - **Files Modified**: Updated `types.gen.ts`, `index.ts`, and `sdk.gen.ts` to reflect the changes in type definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the SDK type definitions and generated client code to improve type safety and introduce support for the
CreateViewRequesttype. The changes span the core SDK layer (sdk/index.ts,sdk/sdk.gen.ts,sdk/types.gen.ts) with a net addition of ~223 new lines, primarily in type definitions.Changes
Type Definitions (
types.gen.ts)CreateViewRequesttype and associated supporting types for view creation workflowsSDK Client (
sdk.gen.ts)SDK Barrel Export (
index.ts)Key Improvements
CreateViewRequestenables programmatic view creation through the SDK, unblocking downstream feature workBreaking Changes
types.gen.tswere refactored (not just extended), any consuming code that relies on the previous type shapes may need to be updated. Reviewers should verify:Testing Notes
CreateViewRequesttsc --noEmitacross the project to catch any type incompatibilities introduced by the refactored typesBrowser Compatibility
No browser compatibility concerns — all changes are TypeScript type definitions and SDK client code that compile down to standard JavaScript. No new runtime APIs, DOM interactions, or CSS changes are introduced.
🤖 Generated with Claude Code
Branch Info:
feature/connection-improvementsmainCo-Authored-By: Claude noreply@anthropic.com